asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Maxon (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1271: Revisit UUID Implementation
Date Fri, 05 Feb 2016 03:30:36 GMT
Ian Maxon has posted comments on this change.

Change subject: ASTERIXDB-1271: Revisit UUID Implementation
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/610/2/asterix-om/src/main/java/org/apache/asterix/om/base/AMutableUUID.java
File asterix-om/src/main/java/org/apache/asterix/om/base/AMutableUUID.java:

Line 39:     public void parseUUIDString(String tokenImage) throws AlgebricksException {
> I think that we should have all of these methods throw HyracksDataException
Yeah, +1 here too. I got confused when I saw AlgebricksException earlier in the review.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/610
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e90d42f6b62f80ad180dbd0c8c852db85b14173
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <michael.blow@couchbase.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message