asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jianfeng Jia (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Add compatibility for Socket adapter
Date Wed, 03 Feb 2016 21:59:06 GMT
Jianfeng Jia has posted comments on this change.

Change subject: Add compatibility for Socket adapter
......................................................................


Patch Set 1:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/609/1/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataCompatibilityUtils.java
File asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataCompatibilityUtils.java:

Line 58:                 throw new AsterixException("Unspecified format parameter for HDFS
adapter");
Is it easy to implement a switch-case-default statement other than if-else statement such
that we won't forget to set some of the configuration in case we add some more adapter in
future?


Line 87:             configuration.put(ExternalDataConstants.KEY_READER_STREAM, ExternalDataConstants.STREAM_SOCKET);
I'm not familiar with Feed configurations, could you explain a bit about what are this two
configurations about? if we don't set these, what could be wrong?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/609
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c8c78598c0cfea36c18503a73b002ece700be71
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Jianfeng Jia <jianfeng.jia@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message