asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Support Sending Messages Alongside Frame Data
Date Wed, 03 Feb 2016 07:48:46 GMT
Till Westmann has posted comments on this change.

Change subject: Support Sending Messages Alongside Frame Data
......................................................................


Patch Set 2:

(2 comments)

For the first round I've got a few questions at the code level.

https://asterix-gerrit.ics.uci.edu/#/c/605/2/asterix-external-data/src/main/java/org/apache/asterix/external/feed/runtime/IngestionRuntime.java
File asterix-external-data/src/main/java/org/apache/asterix/external/feed/runtime/IngestionRuntime.java:

Line 57:         ctx.setObject("feedId", feedId);
Does anybody read this feedId? If so, "feedId" should probably be a constant.


https://asterix-gerrit.ics.uci.edu/#/c/605/2/asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapterFactory.java
File asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapterFactory.java:

Line 86:                             forwarder.initialize((IHyracksTaskContext) ctx, writer);
This cast seems wrong. Why is it ok to know that the implementation of ctx also implements
IHyracksTaskContext?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/605
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa23e9f8a909ddcafc1c3ee95181092eb04ee1ad
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <yingyib@google.com>
Gerrit-HasComments: Yes

Mime
View raw message