Return-Path: X-Original-To: apmail-asterixdb-notifications-archive@minotaur.apache.org Delivered-To: apmail-asterixdb-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A33BB183AA for ; Fri, 29 Jan 2016 20:09:00 +0000 (UTC) Received: (qmail 25267 invoked by uid 500); 29 Jan 2016 20:08:57 -0000 Delivered-To: apmail-asterixdb-notifications-archive@asterixdb.apache.org Received: (qmail 25234 invoked by uid 500); 29 Jan 2016 20:08:57 -0000 Mailing-List: contact notifications-help@asterixdb.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.incubator.apache.org Delivered-To: mailing list notifications@asterixdb.incubator.apache.org Received: (qmail 25225 invoked by uid 99); 29 Jan 2016 20:08:57 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Jan 2016 20:08:57 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 3228FC129B for ; Fri, 29 Jan 2016 20:08:57 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.92 X-Spam-Level: X-Spam-Status: No, score=0.92 tagged_above=-999 required=6.31 tests=[SPF_FAIL=0.919, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id dXqKsOIloyQD for ; Fri, 29 Jan 2016 20:08:50 +0000 (UTC) Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu [128.195.14.130]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with ESMTP id 048A4205F5 for ; Fri, 29 Jan 2016 20:08:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by unhygienix.ics.uci.edu (Postfix) with ESMTP id BD02324195D; Fri, 29 Jan 2016 12:04:39 -0800 (PST) Date: Fri, 29 Jan 2016 12:04:39 -0800 From: "Till Westmann (Code Review)" To: abdullah alamoudi CC: Jenkins , Young-Seok Kim , Taewoo Kim Reply-To: tillw@apache.org X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: Add Support for Upsert Operation X-Gerrit-Change-Id: I8999000331795a5949d621d2dd003903e057a521 X-Gerrit-ChangeURL: X-Gerrit-Commit: 778a380436769a2bd7529a69c5fd3c2cb10f3292 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.8.4 Message-Id: <20160129200439.BD02324195D@unhygienix.ics.uci.edu> Till Westmann has posted comments on this change. Change subject: Add Support for Upsert Operation ...................................................................... Patch Set 17: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/477/17/asterix-om/src/main/java/org/apache/asterix/om/types/BuiltinType.java File asterix-om/src/main/java/org/apache/asterix/om/types/BuiltinType.java: Line 315: public static final byte SERIALIZED_NULL_TYPE_TAG = BuiltinType.ANULL.getTypeTag().serialize(); Can we remove this now and use the one in ATypeTag? -- To view, visit https://asterix-gerrit.ics.uci.edu/477 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8999000331795a5949d621d2dd003903e057a521 Gerrit-PatchSet: 17 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Young-Seok Kim Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: Yes