Return-Path: X-Original-To: apmail-asterixdb-notifications-archive@minotaur.apache.org Delivered-To: apmail-asterixdb-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C26D818BAF for ; Fri, 8 Jan 2016 04:19:09 +0000 (UTC) Received: (qmail 72571 invoked by uid 500); 8 Jan 2016 04:19:09 -0000 Delivered-To: apmail-asterixdb-notifications-archive@asterixdb.apache.org Received: (qmail 72542 invoked by uid 500); 8 Jan 2016 04:19:09 -0000 Mailing-List: contact notifications-help@asterixdb.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.incubator.apache.org Delivered-To: mailing list notifications@asterixdb.incubator.apache.org Received: (qmail 72533 invoked by uid 99); 8 Jan 2016 04:19:09 -0000 Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Jan 2016 04:19:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 3EBAFC0D15 for ; Fri, 8 Jan 2016 04:19:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.92 X-Spam-Level: X-Spam-Status: No, score=0.92 tagged_above=-999 required=6.31 tests=[SPF_FAIL=0.919, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id zI1IjxaC9ndx for ; Fri, 8 Jan 2016 04:18:59 +0000 (UTC) Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu [128.195.14.130]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with ESMTP id AE4C02026F for ; Fri, 8 Jan 2016 04:18:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by unhygienix.ics.uci.edu (Postfix) with ESMTP id 054C42412E3; Thu, 7 Jan 2016 20:15:09 -0800 (PST) Date: Thu, 7 Jan 2016 20:15:08 -0800 From: "abdullah alamoudi (Code Review)" To: Steven Jacobs CC: Ildar Absalyamov , Preston Carman , Jenkins , Till Westmann Reply-To: bamousaa@gmail.com X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses X-Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb X-Gerrit-ChangeURL: X-Gerrit-Commit: d34900355df2648e0d806b22998c2af34f323a71 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.8.4 Message-Id: <20160108041509.054C42412E3@unhygienix.ics.uci.edu> abdullah alamoudi has posted comments on this change. Change subject: Enabled Datasets to use Datatypes from foreign Dataverses ...................................................................... Patch Set 11: Hi Steven, I read the previous comments and saw the statement about the tests duplicating the work. Can you point out for every test which existing test cases covers them already?. Just want to be safe. Other than this, I am good with this change. -- To view, visit https://asterix-gerrit.ics.uci.edu/558 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Preston Carman Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No