asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: some exception cleanup for external data
Date Sat, 30 Jan 2016 06:12:22 GMT
Till Westmann has posted comments on this change.

Change subject: some exception cleanup for external data
......................................................................


Patch Set 1:

(9 comments)

Thanks - I'm actually not completely sure yet, that this is that way I'd like it to be. However,
there clearly is room for cleanup in the area of exceptions.

https://asterix-gerrit.ics.uci.edu/#/c/603/1/asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/DatasourceAdapterTupleTranslator.java
File asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/DatasourceAdapterTupleTranslator.java:

Line 132:         tupleBuilder.addFieldEndOffset();
Keep Metadata exception?


https://asterix-gerrit.ics.uci.edu/#/c/603/1/asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/ExternalFileTupleTranslator.java
File asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/ExternalFileTupleTranslator.java:

Line 171:         recordBuilder.write(tupleBuilder.getDataOutput(), true);
Keep MetadataException?


https://asterix-gerrit.ics.uci.edu/#/c/603/1/asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/FeedPolicyTupleTranslator.java
File asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/FeedPolicyTupleTranslator.java:

Line 164:         recordBuilder.write(tupleBuilder.getDataOutput(), true);
Keep MetadataException?


https://asterix-gerrit.ics.uci.edu/#/c/603/1/asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/FunctionTupleTranslator.java
File asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/FunctionTupleTranslator.java:

Line 185:         recordBuilder.write(tupleBuilder.getDataOutput(), true);
Keep MetadataException?


https://asterix-gerrit.ics.uci.edu/#/c/603/1/asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/IndexTupleTranslator.java
File asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/IndexTupleTranslator.java:

Line 255:             recordBuilder.addField(nameValue, fieldValue);
Keep MetadataException?


Line 277:             recordBuilder.addField(nameValue, fieldValue);
Keep MetadataException?


Line 288:             recordBuilder.addField(nameValue, fieldValue);
Keep MetadataException?


Line 292:         recordBuilder.write(tupleBuilder.getDataOutput(), true);
Keep MetadataException?


https://asterix-gerrit.ics.uci.edu/#/c/603/1/asterix-om/src/main/java/org/apache/asterix/builders/RecordBuilder.java
File asterix-om/src/main/java/org/apache/asterix/builders/RecordBuilder.java:

Line 278:             throw new HyracksDataException(ioe);
separate method?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/603
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf9591046c44f5fa2281874ff0c98d780e741267
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message