asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1281 - Interval format update to AQL and ADM
Date Fri, 29 Jan 2016 20:23:41 GMT
Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1281 - Interval format update to AQL and ADM
......................................................................


Patch Set 1:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/602/1/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AIntervalPrinter.java
File asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AIntervalPrinter.java:

Line 54:                     AIntervalSerializerDeserializer.getStartSize(b, s + 1), ps);
> These should definitely come from the AIntervalSerializerDeserializer (or o
Sorry, I chose the wrong words. I didn't mean constants. I meant variables for the expressions
that depend on "b" and "s". As "b" and "s" don't change I think that we could put the interval
start and end offsets and sizes into named variables before the if statement. Then the code
would be a little less busy.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/602
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I009c71b7a445d141e228ba15d56d0b6cf3c8a3f5
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Preston Carman <prestonc@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <prestonc@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message