asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Add flush() to IFrameWriter
Date Thu, 28 Jan 2016 14:58:02 GMT
abdullah alamoudi has posted comments on this change.

Change subject: Add flush() to IFrameWriter
......................................................................


Patch Set 8:

(22 comments)

https://asterix-gerrit.ics.uci.edu/#/c/585/8/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/CouchbaseReader.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/CouchbaseReader.java:

Line 86:         this.feedName = feedName;
> Make these final
Done


Line 158:                             System.err.println(message.key() + " was deleted.");
> Create logger
Done


Line 170:                     done = true;
> call close()
Done


Line 189:         if (message.key() == null) {
> change this to check for the stop msg by reference
Done


https://asterix-gerrit.ics.uci.edu/#/c/585/8/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/HDFSRecordReader.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/HDFSRecordReader.java:

Line 197:     public void setController(AbstractFeedDataFlowController controller) {
> remove method and add default to throw unsupportedOp
Done


https://asterix-gerrit.ics.uci.edu/#/c/585/8/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/RSSRecordReader.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/RSSRecordReader.java:

Line 147:         // TODO Auto-generated method stub
> remove method and add default to throw unsupportedOp
Done


https://asterix-gerrit.ics.uci.edu/#/c/585/8/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/TwitterPullRecordReader.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/TwitterPullRecordReader.java:

Line 108:     public void setController(AbstractFeedDataFlowController controller) {
> remove method and add default to throw unsupportedOp
Done


https://asterix-gerrit.ics.uci.edu/#/c/585/8/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/TwitterPushRecordReader.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/TwitterPushRecordReader.java:

Line 134:     public void setController(AbstractFeedDataFlowController controller) {
> remove method and add default to throw unsupportedOp
Done


https://asterix-gerrit.ics.uci.edu/#/c/585/8/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/factory/CouchbaseReaderFactory.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/factory/CouchbaseReaderFactory.java:

Line 55:     public static final long AUTO_RELEASE_AFTER = 5000L;
> rename to include unit
Done


Line 79:         clusterLocations = CouchbaseReaderFactory.getAllPartitions(clusterLocations);
> Replace this by AsterixClusterProperties.INSTANCE.getClusterLocations()
Done


Line 94:         if (configuration.containsKey(ExternalDataConstants.KEY_PASSWORD)) {
> Move all checks up
Done


Line 110:         for (int i = 0; i < numOfVBuckets; i++) {
> put comment to describe the assignment
Done


Line 138:         ArrayList<Short> list = new ArrayList<>();
> Rename this
Done


Line 161:     public static AlgebricksAbsolutePartitionConstraint getAllPartitions(
> Removed this method.
Done


https://asterix-gerrit.ics.uci.edu/#/c/585/8/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStream.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStream.java:

Line 30:     public void setController(AbstractFeedDataFlowController controller) {
> throw unsupportedOp
Done


https://asterix-gerrit.ics.uci.edu/#/c/585/8/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFileSystemInputStream.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFileSystemInputStream.java:

Line 44:         watcher.subscribeToEvents(controller);
> rename to setController
Done


https://asterix-gerrit.ics.uci.edu/#/c/585/8/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaNodePushable.java
File asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaNodePushable.java:

Line 186:         if (inputSideHandler != null) {
> Revise this behavior.
Done


https://asterix-gerrit.ics.uci.edu/#/c/585/8/asterix-external-data/src/main/java/org/apache/asterix/external/parser/RecordWithMetaParser.java
File asterix-external-data/src/main/java/org/apache/asterix/external/parser/RecordWithMetaParser.java:

Line 40: public class RecordWithMetaParser<T> implements IRecordDataParser<RecordWithMeta<T>>
{
> Rename to RecordWihtMetadata
Done


Line 58:         this.metaIndexes = metaIndexes;
> Change to final
Done


https://asterix-gerrit.ics.uci.edu/#/c/585/8/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/RecordWithMetaParserFactory.java
File asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/RecordWithMetaParserFactory.java:

Line 36: public class RecordWithMetaParserFactory<T> implements IRecordDataParserFactory<RecordWithMeta<T>>
{
> Rename
Done


Line 54:         if (configuration.containsKey(ExternalDataConstants.KEY_META_INDEXES)) {
> make all checks at the beginning
Done


https://asterix-gerrit.ics.uci.edu/#/c/585/8/asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
File asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java:

Line 251:     public void subscribeToEvents(AbstractFeedDataFlowController controller) {
> rename to setController
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/585
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id862ce9e9b1360864c6976f2aea2137092f51203
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message