asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Heri Ramampiaro (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1255: Fix for potential issues related to object c...
Date Wed, 27 Jan 2016 11:49:36 GMT
Heri Ramampiaro has posted comments on this change.

Change subject: ASTERIXDB-1255: Fix for potential issues related to object creation in Jaccard
Similarity evaluation
......................................................................


Patch Set 2:

(2 comments)

Thanks, Yingyi. It is fine. See my comments below.

Best,
-heri

https://asterix-gerrit.ics.uci.edu/#/c/586/2/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/SimilarityJaccardEvaluator.java
File asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/SimilarityJaccardEvaluator.java:

Line 241:         if (hashMap != null) {
> More specifically, if the incoming buildItemTypeTag and probeItemTypeTag ar
My tests show have shown that this should not be a problem.


Line 243:             return;
> It looks this if-block makes sure the object creation only happen once.
Yes, I also see now that the original code was fine. A change that I still would suggest keeping
though is replacing the table size from the default fixed value (TABLE_SIZE) to a dynamically
set size... Any thoughts?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/586
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08c550d35d864df08792369d38ff81012e3976af
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Heri Ramampiaro <heriram@gmail.com>
Gerrit-Reviewer: Chen Li <chenli@gmail.com>
Gerrit-Reviewer: Heri Ramampiaro <heriram@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message