asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yingyi Bu (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1255: Fix for potential issues related to object c...
Date Wed, 27 Jan 2016 02:24:46 GMT
Yingyi Bu has posted comments on this change.

Change subject: ASTERIXDB-1255: Fix for potential issues related to object creation in Jaccard
Similarity evaluation
......................................................................


Patch Set 2:

(1 comment)

Heri,

   After double checking, now I think the old code was fine (detailed thoughts are inlined).
 Sorry for the confusion.  But I still didn't get whether or how the similarity function can
handle heterogenous list. 
Best,
Yingyi

https://asterix-gerrit.ics.uci.edu/#/c/586/2/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/SimilarityJaccardEvaluator.java
File asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/SimilarityJaccardEvaluator.java:

Line 243:             return;
It looks this if-block makes sure the object creation only happen once.
I didn't get that part last time. Now I think the old code was fine, in terms of object creation.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/586
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08c550d35d864df08792369d38ff81012e3976af
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Heri Ramampiaro <heriram@gmail.com>
Gerrit-Reviewer: Chen Li <chenli@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message