asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taewoo Kim (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1277 - Updated interval desc sort to be based on e...
Date Tue, 26 Jan 2016 20:19:46 GMT
Taewoo Kim has posted comments on this change.

Change subject: ASTERIXDB-1277 - Updated interval desc sort to be based on end point.
......................................................................


Patch Set 3: Code-Review+2

(2 comments)

LGTM - just two minor comments.

https://asterix-gerrit.ics.uci.edu/#/c/598/3/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/AIntervalSerializerDeserializer.java
File asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/AIntervalSerializerDeserializer.java:

Line 33:     private static final int INTERVAL_START_POINT_OFFSET = 0;
Each increases by 8 since sizeof(long) is 8 in C++ terminology? Maybe we can add that fact
here for the future references.


https://asterix-gerrit.ics.uci.edu/#/c/598/3/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/AqlBinaryComparatorFactoryProvider.java
File asterix-om/src/main/java/org/apache/asterix/formats/nontagged/AqlBinaryComparatorFactoryProvider.java:

Line 228:     private IBinaryComparatorFactory intervalBinaryComparatorFactory(boolean ascending)
{
Again, it may be better to put some comments here why we treat intervalComparators differently.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/598
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I61d00850e0bc8ebc611366b95e2aa4da07d21d55
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Preston Carman <prestonc@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <prestonc@apache.org>
Gerrit-Reviewer: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: Taewoo Kim <wangsaeu@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message