asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in hyracks[master]: ASTERIXDB-1272 Remove ExternalLookupOperator
Date Mon, 25 Jan 2016 04:48:55 GMT
Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1272 Remove ExternalLookupOperator
......................................................................


Patch Set 2:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/591/2/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/SchemaVariableVisitor.java
File algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/SchemaVariableVisitor.java:

Line 248:             return null;
> propagateInput() depends on whether the index search is used to do outer jo
I'm still a little confused, but probably because my first comment was to vague. 
I'll try with separate questions:
1) Why do we need a "return" statement in the first branch? It seems that not having the statement
should yield the same result.
2) I think that my first idea on this was wrong. However, I'm wondering if the structure

if (isInternal()) {
  if (propagatesInput()) {
  } else {
  }
} else {
}

would work and would make it clearer, that propagatesInput() only is relevant for internal
uses of UnnestMap?


https://asterix-gerrit.ics.uci.edu/#/c/591/2/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitor.java
File algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitor.java:

Line 278:                     .append("unnest-map(external) " + op.getVariables() + " <-
" + op.getExpressionRef().getValue());
> You are right. this only depends on whether we want to show the user that t
I think that it should be relatively obvious as I expect that printing the op.getExpressionRef().getValue()
will contain "external-lookup".
Is that right? If so, I think that we should change it.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/591
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86489a96932006bf689ba7c0c7b2f2dd8b0f8be0
Gerrit-PatchSet: 2
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <yingyib@google.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message