asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Maxon (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Asterix NCs Fault Tolerance
Date Sat, 23 Jan 2016 00:58:58 GMT
Ian Maxon has posted comments on this change.

Change subject: Asterix NCs Fault Tolerance
......................................................................


Patch Set 6:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/573/6/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixAppRuntimeContext.java
File asterix-app/src/main/java/org/apache/asterix/api/common/AsterixAppRuntimeContext.java:

Line 420:         ExternalLibraryBootstrap.setUpExternaLibraries(isMetadataNode);
We don't end up importing the metadata from the library XML twice when we do this on failover,
right?


https://asterix-gerrit.ics.uci.edu/#/c/573/6/asterix-om/src/main/java/org/apache/asterix/om/util/AsterixClusterProperties.java
File asterix-om/src/main/java/org/apache/asterix/om/util/AsterixClusterProperties.java:

Line 335:             } catch (Exception e) {
Is there something else to do here besides printing the stack maybe?


Line 380:         } catch (Exception e) {
Ditto with above comment.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/573
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice26d980912a315fcb3efdd571d6ce88717cfea4
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message