asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in hyracks[master]: Pass task partition to IPushRuntime
Date Wed, 20 Jan 2016 20:03:28 GMT
Till Westmann has posted comments on this change.

Change subject: Pass task partition to IPushRuntime
......................................................................


Patch Set 1:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/589/1/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/base/IPushRuntimeFactory.java
File algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/base/IPushRuntimeFactory.java:

Line 28:     public IPushRuntime createPushRuntime(IHyracksTaskContext ctx, int partition)
throws AlgebricksException, HyracksDataException;
Haven't looked in detail, but I'm wondering if it would be better to add the partition to
the TaskContext. I think that we do have 1 Task object per partition, is that right?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/589
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iddd566ea97512c1dbd2217befdc2bb8822e77763
Gerrit-PatchSet: 1
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message