asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yingyi Bu (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Fixed ASTERIXDB-1249 and ASTERIXDB-1250: self index-nested-l...
Date Wed, 20 Jan 2016 18:35:28 GMT
Yingyi Bu has posted comments on this change.

Change subject: Fixed ASTERIXDB-1249 and ASTERIXDB-1250: self index-nested-loop join correctly
identifies the outer and the inner branch.
......................................................................


Patch Set 6: Code-Review+1

(1 comment)

Just one minor comment inlined.

https://asterix-gerrit.ics.uci.edu/#/c/576/6/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
File asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java:

Line 751:                 && funcIdent != AsterixBuiltinFunctions.CREATE_LINE &&
funcIdent != AsterixBuiltinFunctions.CREATE_POINT
can you use a static set to store the desired function identifiers?
You can use com.google.common.collect.ImmutableSet and say "ImmutableSet.of(....)".


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/576
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0d4291197c2bcfbcdcde998c5952af41960c4ad7
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wangsaeu@gmail.com>
Gerrit-Reviewer: Ildar Absalyamov <ildar.absalyamov@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wangsaeu@gmail.com>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message