asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steven Jacobs (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1261 Fixed the printer for UUID UUIDPrinter no lon...
Date Tue, 19 Jan 2016 17:37:20 GMT
Steven Jacobs has posted comments on this change.

Change subject: ASTERIXDB-1261 Fixed the printer for UUID UUIDPrinter no longer has a UUID
object The print function doesn't create any objects
......................................................................


Patch Set 2:

toStringLiteralOnly creates several objects per record (I think 6 strings and 30 char[]),
which seems much worse to me (although I'm not much of a Java expert). Am I missing something
there?

Maybe we should chat about this (perhaps with Yingyi as well, who I think was in charge of
optimizing the other Printers)?

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/587
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie33dc8b02e32b3e85a3cb64ef08cb028a50f4ca0
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: Taewoo Kim <wangsaeu@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: No

Mime
View raw message