asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steven Jacobs (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1261 Fixed the printer for UUID UUIDPrinter no lon...
Date Mon, 18 Jan 2016 19:34:58 GMT
Steven Jacobs has posted comments on this change.

Change subject: ASTERIXDB-1261 Fixed the printer for UUID UUIDPrinter no longer has a UUID
object The print function doesn't create any objects
......................................................................


Patch Set 1:

(2 comments)

I'm uploading a new patch with the function commented.

https://asterix-gerrit.ics.uci.edu/#/c/587/1/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/PrintTools.java
File asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/PrintTools.java:

Line 201:     private static void printPart(long value, int digs, PrintStream ps) {
> For future references, can we put a reference link (like wikipedia?) here t
This basically mimics some of the work done by Long.toHexString but without creating objects.
I'll add a comment to that effect.


Line 212:             ps.print(digits[newValue & mask]);
> Where does this "digits" come from?
It mimics the array used internally by the Integer class (not visible) which Long.toHexString
uses


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/587
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie33dc8b02e32b3e85a3cb64ef08cb028a50f4ca0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: Taewoo Kim <wangsaeu@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message