asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Maxon (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in hyracks[master]: Fix for ASTERIXDB-1247
Date Thu, 07 Jan 2016 20:40:56 GMT
Ian Maxon has posted comments on this change.

Change subject: Fix for ASTERIXDB-1247
......................................................................


Patch Set 2:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/575/2/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
File hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java:

Line 1204:                    return false;
> return true.
D'oh!


https://asterix-gerrit.ics.uci.edu/#/c/575/2/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/btree/OrderedIndexExamplesTest.java
File hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/btree/OrderedIndexExamplesTest.java:

Line 745:             treeIndex.getBufferCache().finishQueue();
> calling finishQueue explicitly here doesn't sound right unless this is a sc
I don't think it is something normal. Basically, from what I can tell, the reason this was
happening was the index would be destroyed before the queue could be written out. Normally
in end() we call finishQueue().


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/575
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia580242b3f7753fc2f793f879332de3270ee3fee
Gerrit-PatchSet: 2
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message