asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ildar Absalyamov (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses
Date Thu, 07 Jan 2016 05:24:35 GMT
Ildar Absalyamov has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 9:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/558/9/asterix-app/src/test/resources/metadata/testsuite.xml
File asterix-app/src/test/resources/metadata/testsuite.xml:

Line 196
OK, but what about test cases 20&21? It seems they are the same as 'metadata_node' and
'metadata_nodegroup'.
On contrary I suggest removing named test cases because doing otherwise breaks the naming
scheme (there will be a gap between 15 and 22)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <ildar.absalyamov@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <prestonc@apache.org>
Gerrit-Reviewer: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message