Return-Path: X-Original-To: apmail-asterixdb-notifications-archive@minotaur.apache.org Delivered-To: apmail-asterixdb-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7EDB41832E for ; Tue, 15 Dec 2015 01:10:51 +0000 (UTC) Received: (qmail 89881 invoked by uid 500); 15 Dec 2015 01:10:51 -0000 Delivered-To: apmail-asterixdb-notifications-archive@asterixdb.apache.org Received: (qmail 89848 invoked by uid 500); 15 Dec 2015 01:10:51 -0000 Mailing-List: contact notifications-help@asterixdb.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.incubator.apache.org Delivered-To: mailing list notifications@asterixdb.incubator.apache.org Received: (qmail 89839 invoked by uid 99); 15 Dec 2015 01:10:51 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Dec 2015 01:10:51 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 9AB771A0405 for ; Tue, 15 Dec 2015 01:10:50 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.92 X-Spam-Level: X-Spam-Status: No, score=0.92 tagged_above=-999 required=6.31 tests=[SPF_FAIL=0.919, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id zgbeiZk9T3Sz for ; Tue, 15 Dec 2015 01:10:49 +0000 (UTC) Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu [128.195.14.130]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with ESMTP id 892C3265FE for ; Tue, 15 Dec 2015 01:10:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by unhygienix.ics.uci.edu (Postfix) with ESMTP id E8D33240343; Mon, 14 Dec 2015 17:07:18 -0800 (PST) Date: Mon, 14 Dec 2015 17:07:18 -0800 From: "Yingyi Bu (Code Review)" To: abdullah alamoudi CC: Jenkins Reply-To: buyingyi@gmail.com X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: Changed the IFrameWriter contract X-Gerrit-Change-Id: Ibcebe876340a25be0f561945582a95211c140e10 X-Gerrit-ChangeURL: X-Gerrit-Commit: 9b5e8187b022432601b9bfee574a414fa5fd3102 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.8.4 Message-Id: <20151215010718.E8D33240343@unhygienix.ics.uci.edu> Yingyi Bu has posted comments on this change. Change subject: Changed the IFrameWriter contract ...................................................................... Patch Set 2: (9 comments) https://asterix-gerrit.ics.uci.edu/#/c/552/2/asterix-app/src/main/java/org/apache/hyracks/dataflow/std/misc/ConstantTupleSourceOperatorNodePushable.java File asterix-app/src/main/java/org/apache/hyracks/dataflow/std/misc/ConstantTupleSourceOperatorNodePushable.java: Line 53: } catch (Exception e) { Exception --> Throwable https://asterix-gerrit.ics.uci.edu/#/c/552/2/asterix-common/src/main/java/org/apache/asterix/common/dataflow/AsterixLSMInsertDeleteOperatorNodePushable.java File asterix-common/src/main/java/org/apache/asterix/common/dataflow/AsterixLSMInsertDeleteOperatorNodePushable.java: Line 76: } catch (Exception e) { Exception --> Throwable Line 119: } catch (Exception e) { Exception --> Throwable Line 132: writer.close(); Should you reverse the places of indexHelper.close() and writer.close()? https://asterix-gerrit.ics.uci.edu/#/c/552/2/asterix-external-data/src/main/java/org/apache/asterix/external/indexing/operators/ExternalIndexBulkModifyOperatorNodePushable.java File asterix-external-data/src/main/java/org/apache/asterix/external/indexing/operators/ExternalIndexBulkModifyOperatorNodePushable.java: Line 97: } catch (Exception e) { Exception-->Throwable https://asterix-gerrit.ics.uci.edu/#/c/552/2/asterix-metadata/src/main/java/org/apache/asterix/metadata/external/ExternalLoopkupOperatorDiscriptor.java File asterix-metadata/src/main/java/org/apache/asterix/metadata/external/ExternalLoopkupOperatorDiscriptor.java: Line 98: } catch (Exception e) { Exception-->Throwable Line 119: throw new HyracksDataException("controlled adapter failed to clean up", e); Remove the wrapped message. https://asterix-gerrit.ics.uci.edu/#/c/552/2/asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/ExternalDataScanOperatorDescriptor.java File asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/ExternalDataScanOperatorDescriptor.java: Line 66: throw new HyracksDataException("exception during reading from external data source", e); remove the wrapped message. https://asterix-gerrit.ics.uci.edu/#/c/552/2/asterix-runtime/src/main/java/org/apache/asterix/runtime/external/ExternalBTreeSearchOperatorNodePushable.java File asterix-runtime/src/main/java/org/apache/asterix/runtime/external/ExternalBTreeSearchOperatorNodePushable.java: Line 84: throw new HyracksDataException("Exception during opening of the search operator for the external index", e); Remove the wrapped message. -- To view, visit https://asterix-gerrit.ics.uci.edu/552 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibcebe876340a25be0f561945582a95211c140e10 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: Yes