asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Murtadha Hubail (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Divide Cluster into Unique Partitions
Date Thu, 31 Dec 2015 16:32:41 GMT
Murtadha Hubail has posted comments on this change.

Change subject: Divide Cluster into Unique Partitions
......................................................................


Patch Set 4:

(6 comments)

On 1, I agree. I changed them back to be called from AqlMetadataProvider.

On 2, the storeDirs value already exists on the asterix config and can be updated (which will
break the storage). However, I removed storageDirName from asterix config and used the one
in cluster config only, and added a default value for virtual clusters without cluster config
file.

https://asterix-gerrit.ics.uci.edu/#/c/564/4/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
File asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java:

Line 322:                     //TODO get it from the properties
> What does this TODO mean?  What does "it" mean?
At one point I was using a static value for storage directory and not reading it from any
configuration file. I removed the comment now and passed the stores configs correctly.


https://asterix-gerrit.ics.uci.edu/#/c/564/4/asterix-app/src/main/resources/asterix-build-configuration.xml
File asterix-app/src/main/resources/asterix-build-configuration.xml:

Line 21:     <storageDirName>storage</storageDirName>
> indent
The indentation in eclipse is displayed correctly. Its just the way gerrit displays spaces
compared to tabs.


Line 28: 		<storeDirs>iodevice0,iodevice1</storeDirs>
> A node can have any number of storeDirs with any name, correct?
Yes, they may have any number of storeDirs and most likely they will be different. But they
will all end with the same storage dir name.

For example:
 NC1 may have:
<storeDirs>/Users/Murtadha/asterix/storage</storeDirs>
NC 2 may have:
<storeDirs>/Users/Yingyi/asterix1/storage,/Users/Yingyi/asterix2/storage</storeDirs>

Remember this file is just a mock file to be used in AsterixHyracksIntergrationUtil. 
Even though these values here look the same, but when AsterixHyracksIntergrationUtil is stared
they look like this:
 <store>
<ncId>asterix_nc1</ncId>
<storeDirs>[java.temp.io]/asterix_nc1/iodevice0/storage,[java.temp.io]/asterix_nc1/iodevice1/storage</storeDirs>
</store>

 <store>
<ncId>asterix_nc2</ncId>
<storeDirs>[java.temp.io]/asterix_nc2/iodevice0/storage,[java.temp.io]/asterix_nc2/iodevice1/storage</storeDirs>
</store>

Thanks to the relative index path, anything before /storage will be pre-appended locally on
each NC based on the IO device number.


https://asterix-gerrit.ics.uci.edu/#/c/564/4/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SplitsAndConstraintsProvider.java
File asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SplitsAndConstraintsProvider.java:

Line 41: 
> If it is a static utility class, it shouldn't be called xxxProvider.
Renamed to SplitsAndConstraintsUtil.


Line 89:                     //format: 'node storage folder' / 'partition_#'/ dataverse /
idx  
> space
Done


https://asterix-gerrit.ics.uci.edu/#/c/564/4/asterix-om/src/main/java/org/apache/asterix/om/util/AsterixClusterProperties.java
File asterix-om/src/main/java/org/apache/asterix/om/util/AsterixClusterProperties.java:

Line 255:     private void printClusterPartitions() {
> This private method seems not used.
Its's just a debugging method, like pretty prints. I removed it since it is easy to rewrite
:-)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/564
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c7fbca5113dd7ad569a46dfa2591addb5bf8655
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message