asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yingyi Bu (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Fix for ASTERIXDB-1018, ASTERIXDB-1017, ASTERIXDB-1019, ASTE...
Date Wed, 30 Dec 2015 21:33:55 GMT
Yingyi Bu has posted comments on this change.

Change subject: Fix for ASTERIXDB-1018, ASTERIXDB-1017, ASTERIXDB-1019, ASTERIXDB-1020, ASTERIXDB-1029,
ASTERIXDB-1030, ASTERIXDB-1034
......................................................................


Patch Set 18:

(4 comments)

https://asterix-gerrit.ics.uci.edu/#/c/489/18//COMMIT_MSG
Commit Message:

Line 13: result should actually be used in introducejoinaccessmethodrule
> capitalization?
Done


Line 15: in abstractintroduceaccessmethodrule.
> capitalization?
Done


https://asterix-gerrit.ics.uci.edu/#/c/489/18/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java
File asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java:

Line 77:             //
> Indentation broken?
I'm not aware of a way to do that.
The old code has the indentation but doesn't follow AsterixCodeStyle...


https://asterix-gerrit.ics.uci.edu/#/c/489/18/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
File asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java:

Line 1260: 
> empty line?
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/489
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc1f844ac6e06e00da3f1618235b6ce9bfd48e9f
Gerrit-PatchSet: 18
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <ildar.absalyamov@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <prestonc@apache.org>
Gerrit-Reviewer: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message