asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Refactored External Data
Date Tue, 22 Dec 2015 17:04:44 GMT
Till Westmann has posted comments on this change.

Change subject: Refactored External Data
......................................................................


Patch Set 2:

(43 comments)

https://asterix-gerrit.ics.uci.edu/#/c/559/2/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/ExternalDataLookupPOperator.java
File asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/ExternalDataLookupPOperator.java:

Line 147:         Pair<IOperatorDescriptor, AlgebricksPartitionConstraint> externalLoopup
= AqlMetadataProvider
s/externalLoopup/externalLookup/


https://asterix-gerrit.ics.uci.edu/#/c/559/2/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java
File asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java:

Line 83:             //
undo reformatting


https://asterix-gerrit.ics.uci.edu/#/c/559/2/asterix-api/.gitignore
File asterix-api/.gitignore:

Line 1: /target/
We only have one .gitignore in AsterixDB.


https://asterix-gerrit.ics.uci.edu/#/c/559/2/asterix-api/pom.xml
File asterix-api/pom.xml:

Line 11:           <groupId>org.apache.hyracks</groupId> 
WS


https://asterix-gerrit.ics.uci.edu/#/c/559/2/asterix-api/src/main/java/org/apache/asterix/api/feed/IFeedLifecycleListener.java
File asterix-api/src/main/java/org/apache/asterix/api/feed/IFeedLifecycleListener.java:

Line 26: public interface IFeedLifecycleListener extends IJobLifecycleListener, IClusterEventsSubscriber
{
Could this be part of the feeds package?


https://asterix-gerrit.ics.uci.edu/#/c/559/2/asterix-api/src/main/java/org/apache/asterix/api/feed/IFeedLoadManager.java
File asterix-api/src/main/java/org/apache/asterix/api/feed/IFeedLoadManager.java:

Line 28: public interface IFeedLoadManager {
Could this also be part of the "private" feeds API?


https://asterix-gerrit.ics.uci.edu/#/c/559/2/asterix-api/src/main/java/org/apache/asterix/api/feed/IFeedPolicyAccessor.java
File asterix-api/src/main/java/org/apache/asterix/api/feed/IFeedPolicyAccessor.java:

Line 24: public interface IFeedPolicyAccessor extends Serializable {
Feeds-private?


https://asterix-gerrit.ics.uci.edu/#/c/559/2/asterix-api/src/main/java/org/apache/asterix/api/feed/IFeedReportMessage.java
File asterix-api/src/main/java/org/apache/asterix/api/feed/IFeedReportMessage.java:

Line 23: public interface IFeedReportMessage extends IFeedMessage {
Feeds-private?


https://asterix-gerrit.ics.uci.edu/#/c/559/2/asterix-api/src/main/java/org/apache/asterix/api/feed/IFeedRuntimeInputHandler.java
File asterix-api/src/main/java/org/apache/asterix/api/feed/IFeedRuntimeInputHandler.java:

Line 25: public interface IFeedRuntimeInputHandler extends IFrameWriter {
Feeds-private?


https://asterix-gerrit.ics.uci.edu/#/c/559/2/asterix-api/src/main/java/org/apache/asterix/api/feed/IFeedTupleCommitAckMessage.java
File asterix-api/src/main/java/org/apache/asterix/api/feed/IFeedTupleCommitAckMessage.java:

Line 21: public interface IFeedTupleCommitAckMessage extends IFeedMessage {
Feeds-private?


https://asterix-gerrit.ics.uci.edu/#/c/559/2/asterix-api/src/main/java/org/apache/asterix/api/feed/IFeedTupleCommitResponseMessage.java
File asterix-api/src/main/java/org/apache/asterix/api/feed/IFeedTupleCommitResponseMessage.java:

Line 21: public interface IFeedTupleCommitResponseMessage extends IFeedMessage {
Feeds-private?


https://asterix-gerrit.ics.uci.edu/#/c/559/2/asterix-api/src/main/java/org/apache/asterix/api/feed/IFrameDistributer.java
File asterix-api/src/main/java/org/apache/asterix/api/feed/IFrameDistributer.java:

Line 21: public interface IFrameDistributer {
Why do we need the interface around the enum?


https://asterix-gerrit.ics.uci.edu/#/c/559/2/asterix-api/src/main/java/org/apache/asterix/api/feed/IMonitoredBuffer.java
File asterix-api/src/main/java/org/apache/asterix/api/feed/IMonitoredBuffer.java:

Line 27: public interface IMonitoredBuffer extends IMessageReceiver<IDataBucket> {
Feeds-private?


https://asterix-gerrit.ics.uci.edu/#/c/559/2/asterix-api/src/main/java/org/apache/asterix/api/feed/INodeLoadReport.java
File asterix-api/src/main/java/org/apache/asterix/api/feed/INodeLoadReport.java:

Line 21: public interface INodeLoadReport extends Comparable<INodeLoadReport> {
Feeds-private?


https://asterix-gerrit.ics.uci.edu/#/c/559/2/asterix-api/src/main/java/org/apache/asterix/api/feed/IScaleInReportMessage.java
File asterix-api/src/main/java/org/apache/asterix/api/feed/IScaleInReportMessage.java:

Line 23: public interface IScaleInReportMessage extends IFeedMessage {
Feeds-private?


https://asterix-gerrit.ics.uci.edu/#/c/559/2/asterix-api/src/main/java/org/apache/asterix/api/feed/ISubscribableFeedRuntimeId.java
File asterix-api/src/main/java/org/apache/asterix/api/feed/ISubscribableFeedRuntimeId.java:

Line 21: public interface ISubscribableFeedRuntimeId extends IFeedRuntimeId {
Feeds-private?


https://asterix-gerrit.ics.uci.edu/#/c/559/2/asterix-api/src/main/java/org/apache/asterix/api/feed/ISubscribableRuntime.java
File asterix-api/src/main/java/org/apache/asterix/api/feed/ISubscribableRuntime.java:

Line 28: public interface ISubscribableRuntime extends IFeedRuntime {
Feeds-private?


https://asterix-gerrit.ics.uci.edu/#/c/559/2/asterix-api/src/main/java/org/apache/asterix/api/feed/IThrottlingEnabledFeedMessage.java
File asterix-api/src/main/java/org/apache/asterix/api/feed/IThrottlingEnabledFeedMessage.java:

Line 21: public interface IThrottlingEnabledFeedMessage extends IFeedMessage {
Feeds-private?


https://asterix-gerrit.ics.uci.edu/#/c/559/2/asterix-api/src/main/java/org/apache/asterix/api/feed/ITupleTrackingFeedAdapter.java
File asterix-api/src/main/java/org/apache/asterix/api/feed/ITupleTrackingFeedAdapter.java:

Line 21: public interface ITupleTrackingFeedAdapter extends IFeedAdapter {
Feeds-private?


https://asterix-gerrit.ics.uci.edu/#/c/559/2/asterix-api/src/main/java/org/apache/asterix/api/om/ICalendarSystem.java
File asterix-api/src/main/java/org/apache/asterix/api/om/ICalendarSystem.java:

Line 25:      * 
WS


Line 40:      * 
WS


Line 55:      * 
WS


https://asterix-gerrit.ics.uci.edu/#/c/559/2/asterix-api/src/main/java/org/apache/asterix/api/om/IObjectFactory.java
File asterix-api/src/main/java/org/apache/asterix/api/om/IObjectFactory.java:

Line 29:      * 
WS


https://asterix-gerrit.ics.uci.edu/#/c/559/2/asterix-api/src/main/java/org/apache/asterix/api/om/base/GregorianCalendarSystem.java
File asterix-api/src/main/java/org/apache/asterix/api/om/base/GregorianCalendarSystem.java:

Line 23:  *Portions of this code are based off of Joda API 
WS


Line 24:  * (http://joda-time.sourceforge.net/) 
WS


Line 120:      * 
WS


Line 172:      * 
WS


Line 187:      * 
WS


Line 204:      * 
WS


Line 220:         // Added milliseconds for days of the month. 
WS


Line 233:      * 
WS


Line 271:      * 
WS


Line 349:      * 
WS


Line 413:      * 
WS


Line 457:      * 
WS


Line 469:      * 
WS


Line 494:      * 
WS


Line 542:      * 
WS


Line 606:      * 
WS


Line 623:      * 
WS


Line 645:      * 
WS


Line 665:      * 
WS


Line 685:      * 
WS


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/559
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I46b60b5e1cc37fd59adc0dd89f374d96502091b2
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message