asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Murtadha Hubail (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Asterix MessageBroker implementation
Date Mon, 21 Dec 2015 20:45:27 GMT
Murtadha Hubail has posted comments on this change.

Change subject: Asterix MessageBroker implementation
......................................................................


Patch Set 10:

(4 comments)

As we agreed, I removed all timeout related things from the MessageBroker and we will have
to worry about them at IPCHandle layer at some point.

@Till,
I'm not exactly sure what you mean by testing messages, but I think every added message should
be tested by its use case. Currently the resource id related messages are implicitly tested
with every test case that has DDL.

https://asterix-gerrit.ics.uci.edu/#/c/486/10/asterix-app/src/main/java/org/apache/asterix/messaging/CCMessageBroker.java
File asterix-app/src/main/java/org/apache/asterix/messaging/CCMessageBroker.java:

Line 75:             reponse.setException(new Exception("Cannot generate global resource id
when cluser is not active."));
> s/cluser/cluster/
Done


https://asterix-gerrit.ics.uci.edu/#/c/486/10/asterix-common/src/main/java/org/apache/asterix/common/messaging/AbstractApplicationMessageCallback.java
File asterix-common/src/main/java/org/apache/asterix/common/messaging/AbstractApplicationMessageCallback.java:

Line 26:     public long getResponseTimeout() {
> If we provide a default implementation of this method on the IApplicationMe
Since we agreed to deal with timeouts at some other point, I removed this class.


https://asterix-gerrit.ics.uci.edu/#/c/486/10/asterix-common/src/main/java/org/apache/asterix/common/messaging/AbstractMessage.java
File asterix-common/src/main/java/org/apache/asterix/common/messaging/AbstractMessage.java:

Line 23: public abstract class AbstractMessage implements IMessage {
> Should this be an AbstractResourceIdMessage? I think that the next user of 
This class now has only the setter and getter for the id attribute. This attribute is required
for Asterix MessageBroker callback contract. I think it should be the abstraction of all messages.


https://asterix-gerrit.ics.uci.edu/#/c/486/10/asterix-common/src/main/java/org/apache/asterix/common/messaging/api/INCMessageBroker.java
File asterix-common/src/main/java/org/apache/asterix/common/messaging/api/INCMessageBroker.java:

Line 37:      * 
> WS
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If4320e2c5a0130d2f86a4be6ae61f5cee43e30af
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Yingyi Bu <yingyib@google.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message