asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Murtadha Hubail (Code Review)" <>
Subject Change in asterixdb[master]: Asterix MessageBroker implementation
Date Mon, 21 Dec 2015 20:45:27 GMT
Murtadha Hubail has posted comments on this change.

Change subject: Asterix MessageBroker implementation

Patch Set 10:


As we agreed, I removed all timeout related things from the MessageBroker and we will have
to worry about them at IPCHandle layer at some point.

I'm not exactly sure what you mean by testing messages, but I think every added message should
be tested by its use case. Currently the resource id related messages are implicitly tested
with every test case that has DDL.
File asterix-app/src/main/java/org/apache/asterix/messaging/

Line 75:             reponse.setException(new Exception("Cannot generate global resource id
when cluser is not active."));
> s/cluser/cluster/
File asterix-common/src/main/java/org/apache/asterix/common/messaging/

Line 26:     public long getResponseTimeout() {
> If we provide a default implementation of this method on the IApplicationMe
Since we agreed to deal with timeouts at some other point, I removed this class.
File asterix-common/src/main/java/org/apache/asterix/common/messaging/

Line 23: public abstract class AbstractMessage implements IMessage {
> Should this be an AbstractResourceIdMessage? I think that the next user of 
This class now has only the setter and getter for the id attribute. This attribute is required
for Asterix MessageBroker callback contract. I think it should be the abstraction of all messages.
File asterix-common/src/main/java/org/apache/asterix/common/messaging/api/

Line 37:      * 
> WS

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: If4320e2c5a0130d2f86a4be6ae61f5cee43e30af
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <>
Gerrit-Reviewer: Ian Maxon <>
Gerrit-Reviewer: Jenkins <>
Gerrit-Reviewer: Murtadha Hubail <>
Gerrit-Reviewer: Till Westmann <>
Gerrit-Reviewer: Yingyi Bu <>
Gerrit-Reviewer: Yingyi Bu <>
Gerrit-Reviewer: abdullah alamoudi <>
Gerrit-HasComments: Yes

View raw message