asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Murtadha Hubail (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in hyracks[master]: Changes required to support MessageBroker implementation
Date Fri, 18 Dec 2015 07:06:24 GMT
Murtadha Hubail has posted comments on this change.

Change subject: Changes required to support MessageBroker implementation
......................................................................


Patch Set 8:

(4 comments)

https://asterix-gerrit.ics.uci.edu/#/c/485/8/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/AbstractRemoteService.java
File hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/AbstractRemoteService.java:

Line 23: public abstract class AbstractRemoteService implements IControllerService {
> Why do you need this abstract class since it just contains a constructor?
This class was already there. I deleted it and made Cluster/NodeControllerService implement
IControllerService


https://asterix-gerrit.ics.uci.edu/#/c/485/8/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/base/INodeController.java
File hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/base/INodeController.java:

Line 57:     public IIPCHandle getIPCHandle();
> It seems to me you don't need to expose IIPCHandle to the outside.
Done


https://asterix-gerrit.ics.uci.edu/#/c/485/8/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/NodeControllerRemoteProxy.java
File hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/NodeControllerRemoteProxy.java:

Line 99:     public IIPCHandle getIPCHandle() {
> Do not expose that.
Done


https://asterix-gerrit.ics.uci.edu/#/c/485/8/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/file/IResourceIdFactory.java
File hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/file/IResourceIdFactory.java:

Line 27:     long createId() throws Exception;
> Exception --> HyracksDataException
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/485
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9f49234eebe912c48e7f71980433a9b42595741
Gerrit-PatchSet: 8
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Yingyi Bu <yingyib@google.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message