asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yingyi Bu (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in hyracks[master]: Changes required to support MessageBroker implementation
Date Thu, 17 Dec 2015 01:22:17 GMT
Yingyi Bu has posted comments on this change.

Change subject: Changes required to support MessageBroker implementation
......................................................................


Patch Set 6:

(8 comments)

https://asterix-gerrit.ics.uci.edu/#/c/485/6/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/application/ICCApplicationContext.java
File hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/application/ICCApplicationContext.java:

Line 67:     public IService getClusterControllerService();
Can you add some annotation for that, just as other interface methods?

Also, is it possible to move up the method to IApplicationContext as "getControllerService"
now?
Since you already have "IService", "getClusterControllerService()" doesn't seem to fully utilize
the abstraction.


https://asterix-gerrit.ics.uci.edu/#/c/485/6/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/application/INCApplicationContext.java
File hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/application/INCApplicationContext.java:

Line 82:     public IService getNodeControllerService();
Similar to ICCApplicationContext, move up this method and add some annotations?


https://asterix-gerrit.ics.uci.edu/#/c/485/6/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/service/IService.java
File hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/service/IService.java:

Line 21: public interface IService {
Rename it to "IControllerService"?
"IService" sounds too general --- a reader might not be able to figure out its specific meaning
immediately.


https://asterix-gerrit.ics.uci.edu/#/c/485/6/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/application/CCApplicationContext.java
File hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/application/CCApplicationContext.java:

Line 117:     public IService getClusterControllerService() {
getClusterControllerService --> getControllerService


https://asterix-gerrit.ics.uci.edu/#/c/485/6/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/base/INodeController.java
File hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/base/INodeController.java:

Line 57:     public IIPCHandle getIPCHandle();
Do you need to expose the IPCHandle?
Where this get method is called? I couldn't find a place.


https://asterix-gerrit.ics.uci.edu/#/c/485/6/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
File hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java:

Line 319:         appCtx = new NCApplicationContext(this,serverCtx, ctx, id, memoryManager,
lccm);
format the code.


https://asterix-gerrit.ics.uci.edu/#/c/485/6/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/application/NCApplicationContext.java
File hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/application/NCApplicationContext.java:

Line 106:     @Override
getNodeControllerSerive --> getControllerService


https://asterix-gerrit.ics.uci.edu/#/c/485/6/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/file/IResourceIdFactory.java
File hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/file/IResourceIdFactory.java:

Line 23:     long createId() throws Exception;
Can you annotate this interface method, e.g., what property this call needs to guarantee,
maybe, a unique return for each call and returned values are monotonically increase.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/485
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9f49234eebe912c48e7f71980433a9b42595741
Gerrit-PatchSet: 6
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Yingyi Bu <yingyib@google.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message