asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yingyi Bu (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Changed the IFrameWriter contract
Date Tue, 15 Dec 2015 01:07:18 GMT
Yingyi Bu has posted comments on this change.

Change subject: Changed the IFrameWriter contract
......................................................................


Patch Set 2:

(9 comments)

https://asterix-gerrit.ics.uci.edu/#/c/552/2/asterix-app/src/main/java/org/apache/hyracks/dataflow/std/misc/ConstantTupleSourceOperatorNodePushable.java
File asterix-app/src/main/java/org/apache/hyracks/dataflow/std/misc/ConstantTupleSourceOperatorNodePushable.java:

Line 53:         } catch (Exception e) {
Exception --> Throwable


https://asterix-gerrit.ics.uci.edu/#/c/552/2/asterix-common/src/main/java/org/apache/asterix/common/dataflow/AsterixLSMInsertDeleteOperatorNodePushable.java
File asterix-common/src/main/java/org/apache/asterix/common/dataflow/AsterixLSMInsertDeleteOperatorNodePushable.java:

Line 76:         } catch (Exception e) {
Exception --> Throwable


Line 119:         } catch (Exception e) {
Exception --> Throwable


Line 132:                 writer.close();
Should you reverse the places of indexHelper.close() and writer.close()?


https://asterix-gerrit.ics.uci.edu/#/c/552/2/asterix-external-data/src/main/java/org/apache/asterix/external/indexing/operators/ExternalIndexBulkModifyOperatorNodePushable.java
File asterix-external-data/src/main/java/org/apache/asterix/external/indexing/operators/ExternalIndexBulkModifyOperatorNodePushable.java:

Line 97:             } catch (Exception e) {
Exception-->Throwable


https://asterix-gerrit.ics.uci.edu/#/c/552/2/asterix-metadata/src/main/java/org/apache/asterix/metadata/external/ExternalLoopkupOperatorDiscriptor.java
File asterix-metadata/src/main/java/org/apache/asterix/metadata/external/ExternalLoopkupOperatorDiscriptor.java:

Line 98:                 } catch (Exception e) {
Exception-->Throwable


Line 119:                     throw new HyracksDataException("controlled adapter failed to
clean up", e);
Remove the wrapped message.


https://asterix-gerrit.ics.uci.edu/#/c/552/2/asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/ExternalDataScanOperatorDescriptor.java
File asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/ExternalDataScanOperatorDescriptor.java:

Line 66:                     throw new HyracksDataException("exception during reading from
external data source", e);
remove the wrapped message.


https://asterix-gerrit.ics.uci.edu/#/c/552/2/asterix-runtime/src/main/java/org/apache/asterix/runtime/external/ExternalBTreeSearchOperatorNodePushable.java
File asterix-runtime/src/main/java/org/apache/asterix/runtime/external/ExternalBTreeSearchOperatorNodePushable.java:

Line 84:             throw new HyracksDataException("Exception during opening of the search
operator for the external index", e);
Remove the wrapped message.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/552
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibcebe876340a25be0f561945582a95211c140e10
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message