asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in incubator-asterixdb-site[asf-site]: Add guide on how to edit site, various tweaks.
Date Wed, 09 Dec 2015 06:04:29 GMT
Till Westmann has posted comments on this change.

Change subject: Add guide on how to edit site, various tweaks.
......................................................................


Patch Set 1:

(4 comments)

https://asterix-gerrit.ics.uci.edu/#/c/541/1/_config.yml
File _config.yml:

Line 14: # Build settings
If we add "destination: content" here, then we don't have to provide it to "jekyll build"
or "jekyll serve".


https://asterix-gerrit.ics.uci.edu/#/c/541/1/site.md
File site.md:

Line 48:         ➤ jekyll serve --watch --destination content/
If we add the destination directive to the _config.yml file, we don't need to specify the
destination here.


Line 53: Right now git gerrit submit isn't used for the website, so you must construct the
proper commit for Gerrit by hand. In your commit message, be sure to include a Commit-Id footer
that is unique to your change. You may take previous Commit-Id: footers as an example.
s/Commit-Id/Change-Id/


Line 54: 
If no Change-Id is provided, "ERROR: missing Change-Id in commit message footer" is reported.
The error description also contains a) a proposal for a Change-Id that can be pasted to the
commit message and b) instructions how to install a commit-msg hook into the local git repository
that will automatically add a Change-Id.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/541
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iadb5074e130d4a42b2af123fa405e9fc21a14aed
Gerrit-PatchSet: 1
Gerrit-Project: incubator-asterixdb-site
Gerrit-Branch: asf-site
Gerrit-Owner: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message