asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jianfeng Jia (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1198: make ISerializerDeserializer implementations...
Date Wed, 02 Dec 2015 02:02:50 GMT
Jianfeng Jia has posted comments on this change.

Change subject: ASTERIXDB-1198: make ISerializerDeserializer implementations in AsterixDB
stateless.
......................................................................


Patch Set 6: Code-Review+1

(1 comment)

LGTM .

So for the serialization-heavy work, it should use the UTF8StringReader/Writer instead of
the AStringSerDer, right? 
We'd better add some guide comments on AStringSerDer.

https://asterix-gerrit.ics.uci.edu/#/c/522/6/asterix-om/src/test/java/org/apache/asterix/dataflow/data/nontagged/serde/SimpleSerializerDeserializerTest.java
File asterix-om/src/test/java/org/apache/asterix/dataflow/data/nontagged/serde/SimpleSerializerDeserializerTest.java:

Line 48:             for (Field field : cl.getDeclaredFields()) {
This is a nice test!


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/522
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I808b6583db6b48a0e9000dcf0ac88c03c336c3a5
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Jianfeng Jia <jianfeng.jia@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message