Return-Path: X-Original-To: apmail-asterixdb-notifications-archive@minotaur.apache.org Delivered-To: apmail-asterixdb-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2F2AB18FF5 for ; Thu, 19 Nov 2015 01:57:45 +0000 (UTC) Received: (qmail 72786 invoked by uid 500); 19 Nov 2015 01:57:45 -0000 Delivered-To: apmail-asterixdb-notifications-archive@asterixdb.apache.org Received: (qmail 72754 invoked by uid 500); 19 Nov 2015 01:57:45 -0000 Mailing-List: contact notifications-help@asterixdb.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.incubator.apache.org Delivered-To: mailing list notifications@asterixdb.incubator.apache.org Received: (qmail 72745 invoked by uid 99); 19 Nov 2015 01:57:45 -0000 Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Nov 2015 01:57:45 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id A3298C07D8 for ; Thu, 19 Nov 2015 01:57:44 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.127 X-Spam-Level: ** X-Spam-Status: No, score=2.127 tagged_above=-999 required=6.31 tests=[MISSING_HEADERS=1.207, SPF_FAIL=0.919, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id khlg3drMQuhi for ; Thu, 19 Nov 2015 01:57:37 +0000 (UTC) Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu [128.195.14.130]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with ESMTP id 21CD0429AA for ; Thu, 19 Nov 2015 01:57:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by unhygienix.ics.uci.edu (Postfix) with ESMTP id 7CE67240C32; Wed, 18 Nov 2015 17:54:29 -0800 (PST) Date: Wed, 18 Nov 2015 17:54:29 -0800 From: "Ian Maxon (Code Review)" CC: Jenkins , Murtadha Hubail , Young-Seok Kim Reply-To: imaxon@apache.org X-Gerrit-MessageType: comment Subject: Change in hyracks[master]: Make LSM bulkload append-only and write-once. X-Gerrit-Change-Id: I80fb891b5310252143854a336b591bf3f8cd4ba7 X-Gerrit-ChangeURL: X-Gerrit-Commit: 8662cc7c0cb2d52beffd6634e379403e04489498 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.8.4 Message-Id: <20151119015429.7CE67240C32@unhygienix.ics.uci.edu> Ian Maxon has posted comments on this change. Change subject: Make LSM bulkload append-only and write-once. ...................................................................... Patch Set 42: (10 comments) Comments from review with Murtadha https://asterix-gerrit.ics.uci.edu/#/c/255/42/hyracks/hyracks-storage-am-bloomfilter/src/main/java/org/apache/hyracks/storage/am/bloomfilter/impls/BloomFilter.java File hyracks/hyracks-storage-am-bloomfilter/src/main/java/org/apache/hyracks/storage/am/bloomfilter/impls/BloomFilter.java: Line 296: public void abort() throws HyracksDataException { Remove this if so an RTE is thrown if the bufferCache is null https://asterix-gerrit.ics.uci.edu/#/c/255/42/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTree.java File hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTree.java: Line 1127: Make this static. https://asterix-gerrit.ics.uci.edu/#/c/255/42/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/freepage/LinkedMetaDataPageManager.java File hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/freepage/LinkedMetaDataPageManager.java: Line 106: int freePage = -1; Change to INVALID_DPID Line 168: if( mdPage <0 ){ change to INVALID_DPID Line 388: return -1; return INVALID_DPID https://asterix-gerrit.ics.uci.edu/#/c/255/42/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/impls/AbstractTreeIndex.java File hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/impls/AbstractTreeIndex.java: Line 38: public static int TREE_METADATA_NUM_PAGES = 2; make final https://asterix-gerrit.ics.uci.edu/#/c/255/42/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/VirtualBufferCache.java File hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/VirtualBufferCache.java: Line 364: throw Unimplemented exception https://asterix-gerrit.ics.uci.edu/#/c/255/42/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTree.java File hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTree.java: Line 103: ws Line 635: forceFlushDirtyPages(bufferCache, fileId, startPage, maxPage); remove silly casts https://asterix-gerrit.ics.uci.edu/#/c/255/42/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java File hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java: Line 117: public static void setDpid(ICachedPage page, long dpid) { make this do the BufferedFileHandle.getDpid thing too -- To view, visit https://asterix-gerrit.ics.uci.edu/255 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80fb891b5310252143854a336b591bf3f8cd4ba7 Gerrit-PatchSet: 42 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Young-Seok Kim Gerrit-HasComments: Yes