Return-Path: X-Original-To: apmail-asterixdb-notifications-archive@minotaur.apache.org Delivered-To: apmail-asterixdb-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8FC3118942 for ; Wed, 18 Nov 2015 19:56:45 +0000 (UTC) Received: (qmail 45927 invoked by uid 500); 18 Nov 2015 19:56:45 -0000 Delivered-To: apmail-asterixdb-notifications-archive@asterixdb.apache.org Received: (qmail 45896 invoked by uid 500); 18 Nov 2015 19:56:45 -0000 Mailing-List: contact notifications-help@asterixdb.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.incubator.apache.org Delivered-To: mailing list notifications@asterixdb.incubator.apache.org Received: (qmail 45887 invoked by uid 99); 18 Nov 2015 19:56:45 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Nov 2015 19:56:45 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 0B63A1A20B4 for ; Wed, 18 Nov 2015 19:56:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.92 X-Spam-Level: X-Spam-Status: No, score=0.92 tagged_above=-999 required=6.31 tests=[SPF_FAIL=0.919, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id mc1kCI8YMz1f for ; Wed, 18 Nov 2015 19:56:36 +0000 (UTC) Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu [128.195.14.130]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with ESMTP id CE88A441A4 for ; Wed, 18 Nov 2015 19:56:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by unhygienix.ics.uci.edu (Postfix) with ESMTP id 59227240C9F; Wed, 18 Nov 2015 11:53:28 -0800 (PST) Date: Wed, 18 Nov 2015 11:53:28 -0800 From: "Yingyi Bu (Code Review)" To: Heri Ramampiaro CC: Steven Jacobs , Preston Carman , Ian Maxon , Jenkins , Till Westmann Reply-To: buyingyi@gmail.com X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: Internal functions for record manipulation, deep equality co... X-Gerrit-Change-Id: I3621ebdd71c7cd91b50d77a972ad863cea7fcbc2 X-Gerrit-ChangeURL: X-Gerrit-Commit: 4e4233dc78dc44f2c3fb6508391cdb8e363d917f In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.8.4 Message-Id: <20151118195328.59227240C9F@unhygienix.ics.uci.edu> Yingyi Bu has posted comments on this change. Change subject: Internal functions for record manipulation, deep equality comparison and fix for ASTERIXDB-1162 ...................................................................... Patch Set 12: (41 comments) https://asterix-gerrit.ics.uci.edu/#/c/298/12/asterix-app/src/test/resources/runtimets/queries/comparison/deep_equal/documentation-example/deep-equal.1.query.aql File asterix-app/src/test/resources/runtimets/queries/comparison/deep_equal/documentation-example/deep-equal.1.query.aql: Line 4: "related":["Hivestrix", "Preglix", "Apache VXQuery"] } ASF header. tab ->spaces. https://asterix-gerrit.ics.uci.edu/#/c/298/12/asterix-app/src/test/resources/runtimets/queries/comparison/deep_equal/documentation-example/deep-equal.2.query.aql File asterix-app/src/test/resources/runtimets/queries/comparison/deep_equal/documentation-example/deep-equal.2.query.aql: Line 1: deep-equal(["Hivestrix", "Preglix", "Apache VXQuery"], ["Hivestrix", "Preglix", "Apache VXQuery"]); ASF header. https://asterix-gerrit.ics.uci.edu/#/c/298/12/asterix-app/src/test/resources/runtimets/queries/comparison/deep_equal/documentation-example/deep-equal.3.query.aql File asterix-app/src/test/resources/runtimets/queries/comparison/deep_equal/documentation-example/deep-equal.3.query.aql: Line 1: deep-equal({{{"s":"Hivestrix", "v":"0.1.0"}, "Preglix", "Apache VXQuery"}}, {{ "Apache VXQuery",{"s":"Hivestrix", "v":"0.1.0"}, "Preglix"}}); ASF header. https://asterix-gerrit.ics.uci.edu/#/c/298/12/asterix-app/src/test/resources/runtimets/queries/comparison/deep_equal/documentation-example/deep-equal.4.query.aql File asterix-app/src/test/resources/runtimets/queries/comparison/deep_equal/documentation-example/deep-equal.4.query.aql: Line 1: deep-equal("test","test"); ASF header. https://asterix-gerrit.ics.uci.edu/#/c/298/12/asterix-app/src/test/resources/runtimets/queries/comparison/deep_equal/documentation-example/deep-equal.5.query.aql File asterix-app/src/test/resources/runtimets/queries/comparison/deep_equal/documentation-example/deep-equal.5.query.aql: Line 1: deep-equal([1,2,3],[1,2,3]); ASF header. https://asterix-gerrit.ics.uci.edu/#/c/298/12/asterix-app/src/test/resources/runtimets/queries/comparison/deep_equal/open-records-example/deep-equal.1.ddl.aql File asterix-app/src/test/resources/runtimets/queries/comparison/deep_equal/open-records-example/deep-equal.1.ddl.aql: Line 3: ASF header. https://asterix-gerrit.ics.uci.edu/#/c/298/12/asterix-app/src/test/resources/runtimets/queries/comparison/deep_equal/open-records-example/deep-equal.2.update.aql File asterix-app/src/test/resources/runtimets/queries/comparison/deep_equal/open-records-example/deep-equal.2.update.aql: Line 1: use dataverse feeds; ASF header. https://asterix-gerrit.ics.uci.edu/#/c/298/12/asterix-app/src/test/resources/runtimets/queries/comparison/deep_equal/open-records-example/deep-equal.3.query.aql File asterix-app/src/test/resources/runtimets/queries/comparison/deep_equal/open-records-example/deep-equal.3.query.aql: Line 1: use dataverse feeds; ASF header. https://asterix-gerrit.ics.uci.edu/#/c/298/12/asterix-app/src/test/resources/runtimets/queries/records/record-add-fields/documentation-example/documentation-example.1.query.aql File asterix-app/src/test/resources/runtimets/queries/records/record-add-fields/documentation-example/documentation-example.1.query.aql: Line 2: * Description : Testing record-add-fields under different queries. ASF header. https://asterix-gerrit.ics.uci.edu/#/c/298/12/asterix-app/src/test/resources/runtimets/queries/records/record-add-fields/documentation-example/documentation-example.2.query.aql File asterix-app/src/test/resources/runtimets/queries/records/record-add-fields/documentation-example/documentation-example.2.query.aql: Line 3: * Expected Res : Success ASF header. https://asterix-gerrit.ics.uci.edu/#/c/298/12/asterix-app/src/test/resources/runtimets/queries/records/record-add-fields/documentation-example/documentation-example.3.query.aql File asterix-app/src/test/resources/runtimets/queries/records/record-add-fields/documentation-example/documentation-example.3.query.aql: Line 4: * Date : 04 Aug 2015 ASF header. https://asterix-gerrit.ics.uci.edu/#/c/298/12/asterix-app/src/test/resources/runtimets/queries/records/record-add-fields/highly-nested-open/highly-nested-open.1.ddl.aql File asterix-app/src/test/resources/runtimets/queries/records/record-add-fields/highly-nested-open/highly-nested-open.1.ddl.aql: Line 5: */ ASF header. https://asterix-gerrit.ics.uci.edu/#/c/298/12/asterix-app/src/test/resources/runtimets/queries/records/record-add-fields/highly-nested-open/highly-nested-open.2.update.aql File asterix-app/src/test/resources/runtimets/queries/records/record-add-fields/highly-nested-open/highly-nested-open.2.update.aql: Line 6: use dataverse test; ASF header. https://asterix-gerrit.ics.uci.edu/#/c/298/12/asterix-app/src/test/resources/runtimets/queries/records/record-add-fields/highly-nested-open/highly-nested-open.3.query.aql File asterix-app/src/test/resources/runtimets/queries/records/record-add-fields/highly-nested-open/highly-nested-open.3.query.aql: Line 5: */ ASF header. https://asterix-gerrit.ics.uci.edu/#/c/298/12/asterix-app/src/test/resources/runtimets/queries/records/record-add-fields/tiny-social-example/tiny-social-example.1.ddl.aql File asterix-app/src/test/resources/runtimets/queries/records/record-add-fields/tiny-social-example/tiny-social-example.1.ddl.aql: Line 7: drop dataverse TinySocial if exists; ASF header. https://asterix-gerrit.ics.uci.edu/#/c/298/12/asterix-app/src/test/resources/runtimets/queries/records/record-add-fields/tiny-social-example/tiny-social-example.2.ddl.aql File asterix-app/src/test/resources/runtimets/queries/records/record-add-fields/tiny-social-example/tiny-social-example.2.ddl.aql: Line 4: * Date : 04 Aug 2015 ASF header. Line 20: hints(cardinality=100); white space. https://asterix-gerrit.ics.uci.edu/#/c/298/12/asterix-app/src/test/resources/runtimets/queries/records/record-add-fields/tiny-social-example/tiny-social-example.3.update.aql File asterix-app/src/test/resources/runtimets/queries/records/record-add-fields/tiny-social-example/tiny-social-example.3.update.aql: Line 4: * Date : 04 Aug 2015 ASF header. https://asterix-gerrit.ics.uci.edu/#/c/298/12/asterix-app/src/test/resources/runtimets/queries/records/record-add-fields/tiny-social-example/tiny-social-example.4.query.aql File asterix-app/src/test/resources/runtimets/queries/records/record-add-fields/tiny-social-example/tiny-social-example.4.query.aql: Line 4: * Date : 04 Aug 2015 ASF header. https://asterix-gerrit.ics.uci.edu/#/c/298/12/asterix-app/src/test/resources/runtimets/queries/records/record-merge/documentation-example/documentation-example.1.query.aql File asterix-app/src/test/resources/runtimets/queries/records/record-merge/documentation-example/documentation-example.1.query.aql: Line 4: * Date : 04 Aug 2015 ASF header. https://asterix-gerrit.ics.uci.edu/#/c/298/12/asterix-app/src/test/resources/runtimets/queries/records/record-merge/documentation-example/documentation-example.2.query.aql File asterix-app/src/test/resources/runtimets/queries/records/record-merge/documentation-example/documentation-example.2.query.aql: Line 5: */ ASF header. https://asterix-gerrit.ics.uci.edu/#/c/298/12/asterix-app/src/test/resources/runtimets/queries/records/record-merge/documentation-example/documentation-example.3.query.aql File asterix-app/src/test/resources/runtimets/queries/records/record-merge/documentation-example/documentation-example.3.query.aql: Line 4: * Date : 04 Aug 2015 ASF header. https://asterix-gerrit.ics.uci.edu/#/c/298/12/asterix-app/src/test/resources/runtimets/queries/records/record-merge/highly-nested-open/highly-nested-open.1.ddl.aql File asterix-app/src/test/resources/runtimets/queries/records/record-merge/highly-nested-open/highly-nested-open.1.ddl.aql: Line 3: * Expected Res : Success ASF header. https://asterix-gerrit.ics.uci.edu/#/c/298/12/asterix-app/src/test/resources/runtimets/queries/records/record-merge/highly-nested-open/highly-nested-open.2.update.aql File asterix-app/src/test/resources/runtimets/queries/records/record-merge/highly-nested-open/highly-nested-open.2.update.aql: Line 3: * Expected Res : Success ASF header. https://asterix-gerrit.ics.uci.edu/#/c/298/12/asterix-app/src/test/resources/runtimets/queries/records/record-merge/highly-nested-open/highly-nested-open.3.query.aql File asterix-app/src/test/resources/runtimets/queries/records/record-merge/highly-nested-open/highly-nested-open.3.query.aql: Line 4: * Date : 04 Aug 2015 ASF header. https://asterix-gerrit.ics.uci.edu/#/c/298/12/asterix-app/src/test/resources/runtimets/queries/records/record-merge/tiny-social-example/tiny-social-example.1.ddl.aql File asterix-app/src/test/resources/runtimets/queries/records/record-merge/tiny-social-example/tiny-social-example.1.ddl.aql: Line 4: * Date : 04 Aug 2015 ASF header. https://asterix-gerrit.ics.uci.edu/#/c/298/12/asterix-app/src/test/resources/runtimets/queries/records/record-merge/tiny-social-example/tiny-social-example.2.ddl.aql File asterix-app/src/test/resources/runtimets/queries/records/record-merge/tiny-social-example/tiny-social-example.2.ddl.aql: Line 4: * Date : 04 Aug 2015 ASF header. Line 19: hints(cardinality=100); white space. https://asterix-gerrit.ics.uci.edu/#/c/298/12/asterix-app/src/test/resources/runtimets/queries/records/record-merge/tiny-social-example/tiny-social-example.3.update.aql File asterix-app/src/test/resources/runtimets/queries/records/record-merge/tiny-social-example/tiny-social-example.3.update.aql: Line 4: * Date : 04 Aug 2015 ASF header. https://asterix-gerrit.ics.uci.edu/#/c/298/12/asterix-app/src/test/resources/runtimets/queries/records/record-merge/tiny-social-example/tiny-social-example.4.query.aql File asterix-app/src/test/resources/runtimets/queries/records/record-merge/tiny-social-example/tiny-social-example.4.query.aql: Line 4: * Date : 04 Aug 2015 ASF header. https://asterix-gerrit.ics.uci.edu/#/c/298/12/asterix-app/src/test/resources/runtimets/queries/records/record-remove-fields/documentation-example/documentation-example.1.query.aql File asterix-app/src/test/resources/runtimets/queries/records/record-remove-fields/documentation-example/documentation-example.1.query.aql: Line 4: * Date : 04 Aug 2015 ASF header. https://asterix-gerrit.ics.uci.edu/#/c/298/12/asterix-app/src/test/resources/runtimets/queries/records/record-remove-fields/documentation-example/documentation-example.2.query.aql File asterix-app/src/test/resources/runtimets/queries/records/record-remove-fields/documentation-example/documentation-example.2.query.aql: Line 3: * Expected Res : Success ASF header. https://asterix-gerrit.ics.uci.edu/#/c/298/12/asterix-app/src/test/resources/runtimets/queries/records/record-remove-fields/documentation-example/documentation-example.3.query.aql File asterix-app/src/test/resources/runtimets/queries/records/record-remove-fields/documentation-example/documentation-example.3.query.aql: Line 3: * Expected Res : Success ASF header. https://asterix-gerrit.ics.uci.edu/#/c/298/12/asterix-app/src/test/resources/runtimets/queries/records/record-remove-fields/highly-nested-open/highly-nested-open.1.ddl.aql File asterix-app/src/test/resources/runtimets/queries/records/record-remove-fields/highly-nested-open/highly-nested-open.1.ddl.aql: Line 4: * Date : 04 Aug 2015 ASF header. https://asterix-gerrit.ics.uci.edu/#/c/298/12/asterix-app/src/test/resources/runtimets/queries/records/record-remove-fields/highly-nested-open/highly-nested-open.2.update.aql File asterix-app/src/test/resources/runtimets/queries/records/record-remove-fields/highly-nested-open/highly-nested-open.2.update.aql: Line 5: */ ASF header. https://asterix-gerrit.ics.uci.edu/#/c/298/12/asterix-app/src/test/resources/runtimets/queries/records/record-remove-fields/highly-nested-open/highly-nested-open.3.query.aql File asterix-app/src/test/resources/runtimets/queries/records/record-remove-fields/highly-nested-open/highly-nested-open.3.query.aql: Line 5: */ ASF header. https://asterix-gerrit.ics.uci.edu/#/c/298/12/asterix-app/src/test/resources/runtimets/queries/records/record-remove-fields/tiny-social-example/tiny-social-example.1.ddl.aql File asterix-app/src/test/resources/runtimets/queries/records/record-remove-fields/tiny-social-example/tiny-social-example.1.ddl.aql: Line 5: */ ASF header. https://asterix-gerrit.ics.uci.edu/#/c/298/12/asterix-app/src/test/resources/runtimets/queries/records/record-remove-fields/tiny-social-example/tiny-social-example.2.ddl.aql File asterix-app/src/test/resources/runtimets/queries/records/record-remove-fields/tiny-social-example/tiny-social-example.2.ddl.aql: Line 6: use dataverse TinySocial; ASF header. Line 19: hints(cardinality=100); white space. https://asterix-gerrit.ics.uci.edu/#/c/298/12/asterix-app/src/test/resources/runtimets/queries/records/record-remove-fields/tiny-social-example/tiny-social-example.3.update.aql File asterix-app/src/test/resources/runtimets/queries/records/record-remove-fields/tiny-social-example/tiny-social-example.3.update.aql: Line 4: * Date : 04 Jun 2015 ASF header. https://asterix-gerrit.ics.uci.edu/#/c/298/12/asterix-app/src/test/resources/runtimets/queries/records/record-remove-fields/tiny-social-example/tiny-social-example.4.query.aql File asterix-app/src/test/resources/runtimets/queries/records/record-remove-fields/tiny-social-example/tiny-social-example.4.query.aql: Line 5: */ ASF header. -- To view, visit https://asterix-gerrit.ics.uci.edu/298 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3621ebdd71c7cd91b50d77a972ad863cea7fcbc2 Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Heri Ramampiaro Gerrit-Reviewer: Heri Ramampiaro Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Preston Carman Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: Yes