asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <>
Subject Change in hyracks[master]: Add Global Resource Id Factory
Date Mon, 30 Nov 2015 22:43:22 GMT
Till Westmann has posted comments on this change.

Change subject: Add Global Resource Id Factory

Patch Set 3:

File hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/application/

Line 28:     public boolean isReadyToProcessUnqiueIdRequests();
Does this need to be on the ApplicationEntryPoint? Would the ApplicationContext be more appropriate?
File hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/application/

Line 32:     public long getNCMaxUniqueId() throws Exception;
This doesn't seem to fit in very well with the lifecycle-oriented methods on this interface?
Is there a better place?
File hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/context/

Line 32: 
Does this need to be part of the RootContext? That seems very high up in the hierarchy.
File hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/base/

Line 75:     public void getUnqiueId(InetSocketAddress ncAddress, String nodeId) throws Exception;
I think that we shouldn't need the ncAddress here? Isn't the nodeId enough to identify the
NC (and thus the address)?
File hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/

Line 1265:         private final InetSocketAddress ncAddress;
Again, I think the we can do without this address.
File hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/

Line 158:     public void getUnqiueId(InetSocketAddress ncAddress, String nodeId) throws Exception
Again, I think the we can do without this address.
File hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/

Line 165:     private final LinkedBlockingQueue<GetUniqueIdResponseFunction> uniqueIdResponseQ;
Why do we need a new queue here?
File hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/file/

Line 28:     private final IHyracksRootContext rootCtx;
Again, this might not need to be the root context.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9f49234eebe912c48e7f71980433a9b42595741
Gerrit-PatchSet: 3
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <>
Gerrit-Reviewer: Ian Maxon <>
Gerrit-Reviewer: Jenkins <>
Gerrit-Reviewer: Murtadha Hubail <>
Gerrit-Reviewer: Till Westmann <>
Gerrit-Reviewer: abdullah alamoudi <>
Gerrit-HasComments: Yes

View raw message