asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Maxon (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Fix ASTERIXDB-1089
Date Wed, 25 Nov 2015 20:58:59 GMT
Ian Maxon has posted comments on this change.

Change subject: Fix ASTERIXDB-1089
......................................................................


Patch Set 3:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/508/3/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
File asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java:

Line 64:     @Option(name = "-metadata-port", usage = "IP port to bind metadata listener (default:
random port)", required = false) public int metadataRmiPort = 0;
> Did you format this with the eclipse profile? This if formatted differently
Yeah, I did, (in IntelliJ no less, based on our conversation on Monday).


Line 294:             Cluster cluster = AsterixClusterProperties.INSTANCE.getCluster();
> cluster itself can be null (like in our execution tests environment or if t
Mm, true. I considered this but I couldn't think of a situation where it would be null. Will
fix.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/508
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8977d91ea82cd3a0538a84dc6d727d94fe2ece1d
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Keren-Audrey Ouaknine <kereno@gmail.com>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message