asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Murtadha Hubail (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Use Global Resource Id Factory in AsterixDB
Date Sun, 22 Nov 2015 07:50:30 GMT
Murtadha Hubail has posted comments on this change.

Change subject: Use Global Resource Id Factory in AsterixDB
......................................................................


Patch Set 2:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/486/2//COMMIT_MSG
Commit Message:

Line 7: Use Global Resource Id Factory in AsterixDB
> Could you add a few more words here?
Done


https://asterix-gerrit.ics.uci.edu/#/c/486/2/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixAppRuntimeContext.java
File asterix-app/src/main/java/org/apache/asterix/api/common/AsterixAppRuntimeContext.java:

Line 145:         //        resourceIdFactory = (new ResourceIdFactoryProvider(localResourceRepository)).createResourceIdFactory();
> Can we remove the commented code?
Done


https://asterix-gerrit.ics.uci.edu/#/c/486/2/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
File asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java:

Line 198:     public boolean isClusterActive() {
> How is this related to the ResourceManager?
It is not. This is needed so that ClusterControllerService can check the cluster state from
here (CCApplicationEntryPoint) based on the application logic. It is used to reject unique
id generation requests when the cluster is not active (not all NCs reported their local maximums).
I renamed it to isReadyToProcessUnqiueIdRequests()


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If4320e2c5a0130d2f86a4be6ae61f5cee43e30af
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message