asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yingyi Bu (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[release-0.8.8]: ASTERIXDB-1109: Fixed deletion of records from open secondar...
Date Wed, 18 Nov 2015 22:12:00 GMT
Yingyi Bu has posted comments on this change.

Change subject: ASTERIXDB-1109: Fixed deletion of records from open secondary index  - Avoided
creating calling record constructor in delete pipeline  - Fixed the case when multiple open
indexes enforce the type of the   same field & covered it with tests
......................................................................


Patch Set 10:

(5 comments)

https://asterix-gerrit.ics.uci.edu/#/c/461/10/asterix-algebra/src/main/java/org/apache/asterix/translator/CompiledStatements.java
File asterix-algebra/src/main/java/org/apache/asterix/translator/CompiledStatements.java:

Line 532:             FLWOGRExpression flowgr = new FLWOGRExpression(clauseList, var);
Can you merge with the latest master and resolve the conflict?
The piece of code goes to this class:
https://github.com/apache/incubator-asterixdb/blob/master/asterix-lang-aql/src/main/java/org/apache/asterix/lang/aql/visitor/AqlDeleteRewriteVisitor.java

It seems I've done a similar change there:-)
So you might need to update AqlDeleteRewriteVisitor.


https://asterix-gerrit.ics.uci.edu/#/c/461/10/asterix-app/src/test/resources/runtimets/queries/open-index-enforced/index-selection/multi-index-composite-key/multi-index-composite-key.2.update.aql
File asterix-app/src/test/resources/runtimets/queries/open-index-enforced/index-selection/multi-index-composite-key/multi-index-composite-key.2.update.aql:

Line 36: 		return $x
tab-->space.


https://asterix-gerrit.ics.uci.edu/#/c/461/10/asterix-app/src/test/resources/runtimets/queries/open-index-enforced/index-selection/multi-index-composite-key/multi-index-composite-key.4.query.aql
File asterix-app/src/test/resources/runtimets/queries/open-index-enforced/index-selection/multi-index-composite-key/multi-index-composite-key.4.query.aql:

Line 33: 	"id": $l.id,
tab-->space.


https://asterix-gerrit.ics.uci.edu/#/c/461/10/asterix-app/src/test/resources/runtimets/queries/open-index-enforced/index-selection/multi-index-composite-key/multi-index-composite-key.6.query.aql
File asterix-app/src/test/resources/runtimets/queries/open-index-enforced/index-selection/multi-index-composite-key/multi-index-composite-key.6.query.aql:

Line 36: 	"age": $l.age,
tab->spaces.


https://asterix-gerrit.ics.uci.edu/#/c/461/10/asterix-app/src/test/resources/runtimets/queries/open-index-enforced/index-selection/multi-index/multi-index.2.update.aql
File asterix-app/src/test/resources/runtimets/queries/open-index-enforced/index-selection/multi-index/multi-index.2.update.aql:

Line 29: );
tab->spaces.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/461
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41bde91401f67918365de7df19dd2f0de20c73d2
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.8.8
Gerrit-Owner: Ildar Absalyamov <ildar.absalyamov@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Ildar Absalyamov <ildar.absalyamov@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wangsaeu@gmail.com>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message