asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taewoo Kim (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1118: allow for lock conversion
Date Wed, 18 Nov 2015 19:05:35 GMT
Taewoo Kim has posted comments on this change.

Change subject: ASTERIXDB-1118: allow for lock conversion
......................................................................


Patch Set 11:

(3 comments)

LGTM. It would be nice if we can put some comments about the classes.

https://asterix-gerrit.ics.uci.edu/#/c/474/11/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/ResourceGroup.java
File asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/ResourceGroup.java:

Line 28: class ResourceGroup {
Can we put general explanation here? What it does and what information it contains.


https://asterix-gerrit.ics.uci.edu/#/c/474/11/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/ResourceGroupTable.java
File asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/ResourceGroupTable.java:

Line 21: class ResourceGroupTable {
Can we put general explanation here? What it does and what information it contains.


https://asterix-gerrit.ics.uci.edu/#/c/474/11/asterix-transactions/src/test/java/org/apache/asterix/transaction/management/service/locking/Locker.java
File asterix-transactions/src/test/java/org/apache/asterix/transaction/management/service/locking/Locker.java:

Line 34: class Locker implements Runnable {
Can we put general explanation here? What it does and what information it contains.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/474
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If49ed8d48fa8c71a52c880d4f42a2badbe6a57d7
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wangsaeu@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Young-Seok Kim <kisskys@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message