asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Murtadha Hubail (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in hyracks[master]: ASTERIXDB-1137: Prevent file from being deleted while a page...
Date Tue, 17 Nov 2015 08:06:12 GMT
Murtadha Hubail has posted comments on this change.

Change subject: ASTERIXDB-1137: Prevent file from being deleted while a page is being flushed.
......................................................................


Patch Set 1:

(1 comment)

I re-triggered the build 6 times to see if the issue would appear and things look good so
far. I also built Asterix locally to make sure this didn't break anything there.

https://asterix-gerrit.ics.uci.edu/#/c/499/1/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
File hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java:

Line 430:         if (!fInfo.fileHasBeenDeleted()) {
> My memory might be a bit rusty, but I think that double-checked locking wor
As we discussed. I removed the first check and made it after the synchronization since the
synchronization cost is already paid on the getFileInfo(.) and a file pages are flushed one
at a time.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/499
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I256a84c416bf9d7251b1ee788d028d6b2928e747
Gerrit-PatchSet: 1
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message