asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Young-Seok Kim (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in hyracks[master]: Add method to check state of buffer cache
Date Tue, 17 Nov 2015 07:08:07 GMT
Young-Seok Kim has posted comments on this change.

Change subject: Add method to check state of buffer cache
......................................................................


Patch Set 5:

(2 comments)

two questions.

https://asterix-gerrit.ics.uci.edu/#/c/497/5/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
File hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java:

Line 497:                 if(c.valid){
what's the purpose/meaning of this flag?


Line 520:                     return true;
Can the "c" in reachableDpids.add(c.dpid) be different from the "cPage" in cPage.dpid? If
yes, is it valid situation to see?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/497
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I80fb891b5310252143854a336b591bf3f8cd4ba8
Gerrit-PatchSet: 5
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Young-Seok Kim <kisskys@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message