asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1118: allow for lock conversion
Date Mon, 16 Nov 2015 23:59:28 GMT
Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1118: allow for lock conversion
......................................................................


Patch Set 8:

(4 comments)

https://asterix-gerrit.ics.uci.edu/#/c/474/8/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/ConcurrentLockManager.java
File asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/ConcurrentLockManager.java:

Line 167:             throw new WaitInterruptedException(txnContext, "interrupted", e);
> Should this exception be ignored if it happens and retry to wait by going w
Since InterruptedException is only thrown, if Thread.interrupt() is called, it is not clear
to me why we should ignore it. 
As we control the JVM and the threads, Thread.interrupt() should only be called if there is
a reason to do so and - if that's the case - the graceful action seems to be stop processing.


Line 257:      * cycle in the wait-graph where the job waits on itself
> Can we add a comment that the depth 0 self-cycle is not a deadlock?
Done


Line 281:                 boolean scanWaiters = true;
> Can we add a comment for the role of this scanWaiters flag?
Done


Line 365:             throw new WaitInterruptedException(txnContext, "interrupted", e);
> same comment:
same reply ;)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/474
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If49ed8d48fa8c71a52c880d4f42a2badbe6a57d7
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wangsaeu@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Young-Seok Kim <kisskys@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message