asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yingyi Bu (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: SQL++ support in AsterixDB: 1. implemented SQL++ expression ...
Date Mon, 16 Nov 2015 20:13:01 GMT
Yingyi Bu has posted comments on this change.

Change subject: SQL++ support in AsterixDB: 1. implemented SQL++ expression to logical plan
translator; 2. refactored REST API to be agnostic of query languages; 3. disabled fuzzy join
queries for SQL++ runtime tests; 4. fixed several rewriting rules.
......................................................................


Patch Set 11:

(2 comments)

Post comments on behalf of Till.

https://asterix-gerrit.ics.uci.edu/#/c/479/11/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/context/Scope.java
File asterix-lang-common/src/main/java/org/apache/asterix/lang/common/context/Scope.java:

Line 172:                     if (symbols.containsKey(symbolFromParent.getValue())) {
goto the next one instead of returning false.


https://asterix-gerrit.ics.uci.edu/#/c/479/11/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/AbstractInlineUdfsVisitor.java
File asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/AbstractInlineUdfsVisitor.java:

Line 260:                 // Rewrite the function body with other rewriting rules.
TODO(yingyib): throw a warning for recursive function call exception.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I82919c4527b304325059519d819a2c30cf2902a9
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message