asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yingyi Bu (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: SQL++ support in AsterixDB: 1. implemented SQL++ expression ...
Date Sat, 14 Nov 2015 01:42:34 GMT
Yingyi Bu has posted comments on this change.

Change subject: SQL++ support in AsterixDB: 1. implemented SQL++ expression to logical plan
translator; 2. refactored REST API to be agnostic of query languages; 3. disabled fuzzy join
queries for SQL++ runtime tests; 4. fixed several rewriting rules.
......................................................................


Patch Set 11:

(28 comments)

Post comments on behalf of Till.

Clean up the varlen-encoding sql++ query file.

https://asterix-gerrit.ics.uci.edu/#/c/479/11/asterix-algebra/src/main/java/org/apache/asterix/algebra/base/ILangExpressionToPlanTranslatorFactory.java
File asterix-algebra/src/main/java/org/apache/asterix/algebra/base/ILangExpressionToPlanTranslatorFactory.java:

Line 40:             int currentVarCounter, String outputDatasetName, ICompiledDmlStatement
stmt) throws AlgebricksException;
See if outputDatasetName is necessary.
See if stmt can be passed to the translator instead of the factory


https://asterix-gerrit.ics.uci.edu/#/c/479/11/asterix-algebra/src/main/java/org/apache/asterix/algebra/base/LogicalOperatorDeepCopyVisitor.java
File asterix-algebra/src/main/java/org/apache/asterix/algebra/base/LogicalOperatorDeepCopyVisitor.java:

Line 488:     }
What's the difference with the one in Algebricks.


https://asterix-gerrit.ics.uci.edu/#/c/479/11/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
File asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java:

Line 701:         Mutable<ILogicalOperator> nestedSource = new MutableObject<ILogicalOperator>(
Enter/exit subplan for the if branch and then enter/exit subplan again for the else branch.


https://asterix-gerrit.ics.uci.edu/#/c/479/11/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
File asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java:

Line 332:                 new LogicalExpressionJobGenToExpressionRuntimeProviderAdapter(AqlLogicalExpressionJobGen.INSTANCE));
Rename the class AqlLogicalExpressionJobGen.


https://asterix-gerrit.ics.uci.edu/#/c/479/11/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/APIServlet.java
File asterix-app/src/main/java/org/apache/asterix/api/http/servlet/APIServlet.java:

Line 145:             AqlTranslator aqlTranslator = new AqlTranslator(aqlStatements, sessionConfig,
compilationProvider);
Rename AqlTranslator.


https://asterix-gerrit.ics.uci.edu/#/c/479/11/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
File asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java:

Line 176:         context.addServlet(new ServletHolder(new QueryAPIServlet(new SqlppCompilationProvider())),
"/sqlpp_query");
query/sqlpp


Line 177:         context.addServlet(new ServletHolder(new UpdateAPIServlet(new SqlppCompilationProvider())),
"/sqlpp_update");
update/sqlpp


Line 178:         context.addServlet(new ServletHolder(new DDLAPIServlet(new SqlppCompilationProvider())),
"/sqlpp_ddl");
ddl/sqlpp


Line 179:         context.addServlet(new ServletHolder(new AQLAPIServlet(new SqlppCompilationProvider())),
"/sqlpp");
sqlpp


https://asterix-gerrit.ics.uci.edu/#/c/479/11/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppExecutionTest.java
File asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppExecutionTest.java:

Line 122:             marshaller.setProperty(javax.xml.bind.Marshaller.JAXB_FORMATTED_OUTPUT,
Boolean.TRUE);
refactor the code to got to some static utils.


https://asterix-gerrit.ics.uci.edu/#/c/479/11/asterix-app/src/test/resources/runtimets/only_sqlpp.xml
File asterix-app/src/test/resources/runtimets/only_sqlpp.xml:

Line 20: <test-suite xmlns="urn:xml.testframework.asterix.apache.org" ResultOffsetPath="results"
QueryOffsetPath="queries">
queries-->queries_sqlpp


https://asterix-gerrit.ics.uci.edu/#/c/479/11/asterix-app/src/test/resources/runtimets/queries/dml/insert-and-scan-joined-datasets/insert-and-scan-joined-datasets.3.query.aql
File asterix-app/src/test/resources/runtimets/queries/dml/insert-and-scan-joined-datasets/insert-and-scan-joined-datasets.3.query.aql:

Line 22:  * is involve a join operation that has the same dataset. We insert a materializing
to prevent the 
WS.


https://asterix-gerrit.ics.uci.edu/#/c/479/11/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv15/cross-dv15.3.query.sqlpp
File asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv15/cross-dv15.3.query.sqlpp:

Line 7:  * 'License'); you may not use this file except in compliance
'-->"


Line 14:  * 'AS IS' BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
'-->"


https://asterix-gerrit.ics.uci.edu/#/c/479/11/asterix-app/src/test/resources/runtimets/queries_sqlpp/dml/insert-and-scan-joined-datasets/insert-and-scan-joined-datasets.1.ddl.sqlpp
File asterix-app/src/test/resources/runtimets/queries_sqlpp/dml/insert-and-scan-joined-datasets/insert-and-scan-joined-datasets.1.ddl.sqlpp:

Line 19: /* 
WS


Line 22:  * is involve a join operation that has the same dataset. We insert a materializing
to prevent the 
WS


https://asterix-gerrit.ics.uci.edu/#/c/479/11/asterix-app/src/test/resources/runtimets/queries_sqlpp/dml/insert-and-scan-joined-datasets/insert-and-scan-joined-datasets.2.update.sqlpp
File asterix-app/src/test/resources/runtimets/queries_sqlpp/dml/insert-and-scan-joined-datasets/insert-and-scan-joined-datasets.2.update.sqlpp:

Line 22:  * is involve a join operation that has the same dataset. We insert a materializing
to prevent the 
WS


https://asterix-gerrit.ics.uci.edu/#/c/479/11/asterix-app/src/test/resources/runtimets/queries_sqlpp/dml/insert-and-scan-joined-datasets/insert-and-scan-joined-datasets.3.query.sqlpp
File asterix-app/src/test/resources/runtimets/queries_sqlpp/dml/insert-and-scan-joined-datasets/insert-and-scan-joined-datasets.3.query.sqlpp:

Line 22:  * is involve a join operation that has the same dataset. We insert a materializing
to prevent the 
WS


https://asterix-gerrit.ics.uci.edu/#/c/479/11/asterix-app/src/test/resources/runtimets/queries_sqlpp/dml/query-issue205/query-issue205.1.ddl.sqlpp
File asterix-app/src/test/resources/runtimets/queries_sqlpp/dml/query-issue205/query-issue205.1.ddl.sqlpp:

Line 25:  
WS


https://asterix-gerrit.ics.uci.edu/#/c/479/11/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-indexing/text-format/text-format.3.query.sqlpp
File asterix-app/src/test/resources/runtimets/queries_sqlpp/external-indexing/text-format/text-format.3.query.sqlpp:

Line 20:  * Description  : Create an external dataset that contains records stored with sequence
hdfs file format.
text


https://asterix-gerrit.ics.uci.edu/#/c/479/11/asterix-app/src/test/resources/runtimets/queries_sqlpp/hdfs/hdfs_03/hdfs_03.1.ddl.sqlpp
File asterix-app/src/test/resources/runtimets/queries_sqlpp/hdfs/hdfs_03/hdfs_03.1.ddl.sqlpp:

Line 22:                  This causes a record to span across the buffer size boundaries.

WS


https://asterix-gerrit.ics.uci.edu/#/c/479/11/asterix-app/src/test/resources/runtimets/queries_sqlpp/hdfs/hdfs_03/hdfs_03.2.update.sqlpp
File asterix-app/src/test/resources/runtimets/queries_sqlpp/hdfs/hdfs_03/hdfs_03.2.update.sqlpp:

Line 22:                  This causes a record to span across the buffer size boundaries.

WS


https://asterix-gerrit.ics.uci.edu/#/c/479/11/asterix-app/src/test/resources/runtimets/queries_sqlpp/hdfs/hdfs_03/hdfs_03.3.query.sqlpp
File asterix-app/src/test/resources/runtimets/queries_sqlpp/hdfs/hdfs_03/hdfs_03.3.query.sqlpp:

Line 22:                  This causes a record to span across the buffer size boundaries.

WS


https://asterix-gerrit.ics.uci.edu/#/c/479/11/asterix-app/src/test/resources/runtimets/queries_sqlpp/hints/issue_251_dataset_hint_5/issue_251_dataset_hint_5.1.ddl.sqlpp
File asterix-app/src/test/resources/runtimets/queries_sqlpp/hints/issue_251_dataset_hint_5/issue_251_dataset_hint_5.1.ddl.sqlpp:

Line 20: * Description  : Create an  dataset and load it from two file splits 
WS


https://asterix-gerrit.ics.uci.edu/#/c/479/11/asterix-app/src/test/resources/runtimets/queries_sqlpp/hints/issue_251_dataset_hint_7/issue_251_dataset_hint_7.1.ddl.sqlpp
File asterix-app/src/test/resources/runtimets/queries_sqlpp/hints/issue_251_dataset_hint_7/issue_251_dataset_hint_7.1.ddl.sqlpp:

Line 22:                   Begin ingestion using a fully qualified name and verify contents
of the dataset post completion.  
Ws


Line 26:  
WS


https://asterix-gerrit.ics.uci.edu/#/c/479/11/asterix-app/src/test/resources/runtimets/queries_sqlpp/hints/issue_251_dataset_hint_7/issue_251_dataset_hint_7.2.update.sqlpp
File asterix-app/src/test/resources/runtimets/queries_sqlpp/hints/issue_251_dataset_hint_7/issue_251_dataset_hint_7.2.update.sqlpp:

Line 22:                   Begin ingestion using a fully qualified name and verify contents
of the dataset post completion.  
WS


https://asterix-gerrit.ics.uci.edu/#/c/479/11/asterix-app/src/test/resources/runtimets/queries_sqlpp/hints/issue_251_dataset_hint_7/issue_251_dataset_hint_7.3.query.sqlpp
File asterix-app/src/test/resources/runtimets/queries_sqlpp/hints/issue_251_dataset_hint_7/issue_251_dataset_hint_7.3.query.sqlpp:

Line 22:                   Begin ingestion using a fully qualified name and verify contents
of the dataset post completion.  
Ws


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I82919c4527b304325059519d819a2c30cf2902a9
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message