asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in hyracks[master]: Add Global Resource Id Factory
Date Fri, 13 Nov 2015 01:31:18 GMT
Till Westmann has posted comments on this change.

Change subject: Add Global Resource Id Factory
......................................................................


Patch Set 1:

(8 comments)

I've added a few comments to individual files. But the bigger questions are (unfortunately
the answers were not obvious to me from looking at the change :) ):

a) What do we use the ResourceIds for and why do the NCs need to agree on them now?
b) Why do the ResourceIds need to be a top-level Hyracks concept (especially outside of storage)
and why is it not sufficient to keep them in AsterixDB?

https://asterix-gerrit.ics.uci.edu/#/c/485/1//COMMIT_MSG
Commit Message:

Line 7: Add Global Resource Id Factory
Could you add a few words about the change after the headline? (Separated by an empty line)


https://asterix-gerrit.ics.uci.edu/#/c/485/1/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/application/ICCApplicationEntryPoint.java
File hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/application/ICCApplicationEntryPoint.java:

Line 27:     
WS


https://asterix-gerrit.ics.uci.edu/#/c/485/1/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/application/INCApplicationEntryPoint.java
File hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/application/INCApplicationEntryPoint.java:

Line 28:     public long getMaxLocalResourceId() throws Exception;
That seems to be a pretty low-level method on a pretty high-level interface ..


https://asterix-gerrit.ics.uci.edu/#/c/485/1/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/context/IHyracksRootContext.java
File hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/context/IHyracksRootContext.java:

Line 31:     public long getResourceId() throws Exception;
What is the resourceId of a HyracksRootContext?


https://asterix-gerrit.ics.uci.edu/#/c/485/1/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerService.java
File hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerService.java:

Line 660:     public synchronized long getResourceId() throws Exception {
If getting the resourceId give a different one every time, the method name should reflect
that.


https://asterix-gerrit.ics.uci.edu/#/c/485/1/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/CCNCFunctions.java
File hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/CCNCFunctions.java:

Line 1260:     
WS


https://asterix-gerrit.ics.uci.edu/#/c/485/1/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/ClusterControllerRemoteProxy.java
File hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/ClusterControllerRemoteProxy.java:

Line 157:     
WS


https://asterix-gerrit.ics.uci.edu/#/c/485/1/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/WorkQueue.java
File hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/WorkQueue.java:

Line 125:                                 + dequeueCount.incrementAndGet() + "/" + enqueueCount);
If there's no change to the semantics of this file, could you revert it?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/485
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9f49234eebe912c48e7f71980433a9b42595741
Gerrit-PatchSet: 1
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message