asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Young-Seok Kim (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1118: allow for lock conversion
Date Thu, 12 Nov 2015 06:19:57 GMT
Young-Seok Kim has posted comments on this change.

Change subject: ASTERIXDB-1118: allow for lock conversion
......................................................................


Patch Set 8:

(4 comments)

Please address comments.

https://asterix-gerrit.ics.uci.edu/#/c/474/8/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/ConcurrentLockManager.java
File asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/ConcurrentLockManager.java:

Line 167:             throw new WaitInterruptedException(txnContext, "interrupted", e);
Should this exception be ignored if it happens and retry to wait by going while loop again?
As long as asterixdb instance or nc is alive, this exception should be handled gracefully
by ignoring the exception, right? Is there any reason not to do so by introducing WaitInterruptedException?


Line 257:      * cycle in the wait-graph where the job waits on itself
Can we add a comment that the depth 0 self-cycle is not a deadlock?


Line 281:                 boolean scanWaiters = true;
Can we add a comment for the role of this scanWaiters flag?


Line 365:             throw new WaitInterruptedException(txnContext, "interrupted", e);
same comment:
Should this exception be ignored if it happens and retry to wait by going while loop again?
As long as asterixdb instance or nc is alive, this exception should be handled gracefully
by ignoring the exception, right? Is there any reason not to do so by introducing WaitInterruptedException?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/474
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If49ed8d48fa8c71a52c880d4f42a2badbe6a57d7
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wangsaeu@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Young-Seok Kim <kisskys@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message