asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ildar Absalyamov (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[release-0.8.8]: ASTERIXDB-1109: Fixed deletion of records from open secondar...
Date Fri, 06 Nov 2015 17:12:36 GMT
Ildar Absalyamov has posted comments on this change.

Change subject: ASTERIXDB-1109: Fixed deletion of records from open secondary index
......................................................................


Patch Set 7:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/461/7/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
File asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java:

Line 268:             // to replicate each <PK,RECORD> pair.
> Is this still true?
Yes, that logic was not changed.


Line 468:     public static ARecordType createEnforcedType(ARecordType initialType, List<Index>
indexes)
> Can we put a comment here? What does this function do?
Done


https://asterix-gerrit.ics.uci.edu/#/c/461/7/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SubstituteEquivalenceClassAssignRule.java
File asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SubstituteEquivalenceClassAssignRule.java:

Line 60:  */
> Does this rule only apply to the assign and project? It looks like it can b
I will put additional restrictions, to that the rule will be applied to assign operators only.
Project operators are not subject to the equivalence class transformation per se, they rather
needed to be adjusted, so that equivalent variable is not projected out by the time the assign[$$var]
<- [$$eqVar] get executed


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/461
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41bde91401f67918365de7df19dd2f0de20c73d2
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.8.8
Gerrit-Owner: Ildar Absalyamov <ildar.absalyamov@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Ildar Absalyamov <ildar.absalyamov@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wangsaeu@gmail.com>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message