asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1126 Correct comparators and type traits for exter...
Date Thu, 05 Nov 2015 05:38:59 GMT
Hello Pouria Pirzadeh, Ian Maxon, Jenkins,

I'd like you to reexamine a change.  Please visit

    https://asterix-gerrit.ics.uci.edu/455

to look at the new patch set (#8).

Change subject: ASTERIXDB-1126 Correct comparators and type traits for external index
......................................................................

ASTERIXDB-1126 Correct comparators and type traits for external index

Turned out, the fix for ASTERIXDB-1115 introduced this bug. the reason is that it tries
to get the data type for the primary key from the record type definition. In case of external
data, the type definition doesn't contain information about primary keys and we should get
them based on the data input format. A test case was added as well.

Change-Id: I71d924d7e2b7a7e6c752bc97679e612946afc17c
---
M asterix-app/pom.xml
M asterix-app/src/test/java/org/apache/asterix/test/runtime/HDFSCluster.java
M asterix-app/src/test/java/org/apache/asterix/test/runtime/RepeatedTest.java
M asterix-common/src/test/java/org/apache/asterix/test/aql/TestsUtils.java
M asterix-installer/pom.xml
M asterix-installer/src/test/java/org/apache/asterix/installer/test/AsterixClusterLifeCycleIT.java
M asterix-installer/src/test/java/org/apache/asterix/installer/transaction/DmlRecoveryIT.java
M asterix-installer/src/test/java/org/apache/asterix/installer/transaction/RecoveryIT.java
A asterix-installer/src/test/resources/transactionts/queries/query_after_restart/external_index/external_index.1.script.aql
A asterix-installer/src/test/resources/transactionts/queries/query_after_restart/external_index/external_index.2.ddl.aql
A asterix-installer/src/test/resources/transactionts/queries/query_after_restart/external_index/external_index.3.script.aql
A asterix-installer/src/test/resources/transactionts/queries/query_after_restart/external_index/external_index.4.query.aql
A asterix-installer/src/test/resources/transactionts/queries/query_after_restart/external_index/external_index.5.script.aql
A asterix-installer/src/test/resources/transactionts/results/query_after_restart/external_index/external_index.1.adm
A asterix-installer/src/test/resources/transactionts/scripts/query_after_restart/external_index/create_and_start.sh
A asterix-installer/src/test/resources/transactionts/scripts/query_after_restart/external_index/stop_and_delete.sh
A asterix-installer/src/test/resources/transactionts/scripts/query_after_restart/external_index/stop_and_start.sh
M asterix-installer/src/test/resources/transactionts/testsuite.xml
M asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
19 files changed, 710 insertions(+), 555 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/55/455/8
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/455
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I71d924d7e2b7a7e6c752bc97679e612946afc17c
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Chris Hillery <ceej@lambda.nu>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Pouria Pirzadeh <pouria.pirzadeh@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Young-Seok Kim <kisskys@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>

Mime
View raw message