asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Preston Carman (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Adding interval merge join.
Date Wed, 04 Nov 2015 16:42:08 GMT
Preston Carman has posted comments on this change.

Change subject: Adding interval merge join.
......................................................................


Patch Set 4:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/457/4/asterix-app/data/csv/sample_01.csv
File asterix-app/data/csv/sample_01.csv:

Line 1: 1,0.899682764,5.6256,2013-08-07,07:22:35,1979-02-25T23:48:27.034
This file should not be changed.


https://asterix-gerrit.ics.uci.edu/#/c/457/4/asterix-lang-aql/src/main/java/org/apache/asterix/lang/aql/util/RangeMapBuilder.java
File asterix-lang-aql/src/main/java/org/apache/asterix/lang/aql/util/RangeMapBuilder.java:

Line 65:         List<Statement> hintStatements;
Use one line to create and assign variable.


https://asterix-gerrit.ics.uci.edu/#/c/457/4/pom.xml
File pom.xml:

Line 146:                 </configuration>
I think this file should not be changed ... revert this?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/457
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id4f9be43eb0c500f04f99438c34e69503591641d
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Preston Carman <prestonc@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <prestonc@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message