Mailing-List: contact notifications-help@asterixdb.incubator.apache.org;
 run by ezmlm
Precedence: bulk
Reply-To: dev@asterixdb.incubator.apache.org
Date: Fri, 23 Oct 2015 18:25:26 -0700
From: "Young-Seok Kim (Code Review)"
 <do-not-reply@asterixdb.incubator.apache.org>
To: Murtadha Hubail <hubailmor@gmail.com>
CC: Jenkins <jenkins@fulliautomatix.ics.uci.edu>,
	Yingyi Bu <buyingyi@gmail.com>,
	abdullah alamoudi <bamousaa@gmail.com>,
	Ian Maxon <imaxon@apache.org>
Reply-To: kisskys@gmail.com
Subject: Change in asterixdb[master]: Introducing Data Replication To
 AsterixDB
In-Reply-To: 
 <gerrit.1438356334922.I729fdd1144dbc9ff039b4bc414494860d7553810@asterix-gerrit.ics.uci.edu>
References: 
 <gerrit.1438356334922.I729fdd1144dbc9ff039b4bc414494860d7553810@asterix-gerrit.ics.uci.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.8.4
Message-Id: <20151024012526.3064E240C74@unhygienix.ics.uci.edu>

Young-Seok Kim has posted comments on this change.

Change subject: Introducing Data Replication To AsterixDB
......................................................................


Patch Set 10:

(6 comments)

Please address comments.

https://asterix-gerrit.ics.uci.edu/#/c/338/10/asterix-replication/src/main/java/org/apache/asterix/replication/management/ReplicationChannel.java
File asterix-replication/src/main/java/org/apache/asterix/replication/management/ReplicationChannel.java:

Line 412:             synchronized (GOODBYE_BUFFER) {
Let's create byte buffer for each request instead of going through sync block and doing IO in it. This seems less harmful based on the fact that sendGoodbye() are used per LSMDiskComponent replication request and sendAck() per file transmission.


Line 414:                 socketChannel.write(GOODBYE_BUFFER);
make sure that the write() return value matches the size of buffer you requested to write.


Line 421:                 socketChannel.write(ACK_BUFFER);
make sure that the write() return value matches the size of buffer you requested to write.


https://asterix-gerrit.ics.uci.edu/#/c/338/10/asterix-replication/src/main/java/org/apache/asterix/replication/management/ReplicationManager.java
File asterix-replication/src/main/java/org/apache/asterix/replication/management/ReplicationManager.java:

Line 1048:         synchronized (GOODBYE_BUFFER) {
let's revert to generate obejcts


https://asterix-gerrit.ics.uci.edu/#/c/338/10/asterix-replication/src/main/java/org/apache/asterix/replication/recovery/RemoteRecoveryManager.java
File asterix-replication/src/main/java/org/apache/asterix/replication/recovery/RemoteRecoveryManager.java:

Line 119:                     //System.out.println("Remote logs found: " + remoteRecoveryLogs.size());
let's remove


https://asterix-gerrit.ics.uci.edu/#/c/338/10/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/recovery/RecoveryManager.java
File asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/recovery/RecoveryManager.java:

Line 142:                 state = SystemState.NEW_UNIVERSE;
Should be CORRUPTED


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/338
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I729fdd1144dbc9ff039b4bc414494860d7553810
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Young-Seok Kim <kisskys@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes