Return-Path: X-Original-To: apmail-asterixdb-notifications-archive@minotaur.apache.org Delivered-To: apmail-asterixdb-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7341818E0E for ; Tue, 6 Oct 2015 18:21:32 +0000 (UTC) Received: (qmail 17027 invoked by uid 500); 6 Oct 2015 18:21:26 -0000 Delivered-To: apmail-asterixdb-notifications-archive@asterixdb.apache.org Received: (qmail 16999 invoked by uid 500); 6 Oct 2015 18:21:26 -0000 Mailing-List: contact notifications-help@asterixdb.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.incubator.apache.org Delivered-To: mailing list notifications@asterixdb.incubator.apache.org Received: (qmail 16990 invoked by uid 99); 6 Oct 2015 18:21:26 -0000 Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Oct 2015 18:21:26 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 94BB1C0419 for ; Tue, 6 Oct 2015 18:21:25 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.919 X-Spam-Level: X-Spam-Status: No, score=0.919 tagged_above=-999 required=6.31 tests=[SPF_FAIL=0.919] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 0sTmw0zzZZhn for ; Tue, 6 Oct 2015 18:21:11 +0000 (UTC) Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu [128.195.14.130]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with ESMTP id 905C223086 for ; Tue, 6 Oct 2015 18:21:11 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by unhygienix.ics.uci.edu (Postfix) with ESMTP id CADA2240F54; Tue, 6 Oct 2015 11:18:40 -0700 (PDT) Date: Tue, 6 Oct 2015 11:18:40 -0700 From: "Ian Maxon (Code Review)" To: Murtadha Hubail , Jenkins Reply-To: imaxon@apache.org X-Gerrit-MessageType: newpatchset Subject: Change in asterixdb[master]: ASTERIXDB-1045: Log analysis fixes X-Gerrit-Change-Id: I1658e938eb0f199f748407361ffee4833aac661c X-Gerrit-ChangeURL: X-Gerrit-Commit: 6fd8553eb311f21a0c9bae9e1a5a26636f6eb7fa In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.8.4 Message-Id: <20151006181840.CADA2240F54@unhygienix.ics.uci.edu> Hello Murtadha Hubail, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/289 to look at the new patch set (#14). Change subject: ASTERIXDB-1045: Log analysis fixes ...................................................................... ASTERIXDB-1045: Log analysis fixes -Avoid using exceptions for control flow in LogRecord -Rename LogPage and ilk to LogBuffer -Busywait on read() to fill entire buffer for fillLogBuffer rather than failing -Distinguish between log truncation and checksum corruption TODOs: - Log IO and parsing still happen in lock-step. - Busywaiting for read to return something other than 0 is unfortunate Change-Id: I1658e938eb0f199f748407361ffee4833aac661c --- R asterix-common/src/main/java/org/apache/asterix/common/transactions/ILogBuffer.java M asterix-common/src/main/java/org/apache/asterix/common/transactions/ILogRecord.java M asterix-common/src/main/java/org/apache/asterix/common/transactions/LogRecord.java M asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/LockManager.java R asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogBuffer.java R asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogBufferTailReader.java M asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java M asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogReader.java 8 files changed, 196 insertions(+), 95 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/89/289/14 -- To view, visit https://asterix-gerrit.ics.uci.edu/289 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1658e938eb0f199f748407361ffee4833aac661c Gerrit-PatchSet: 14 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Young-Seok Kim