Return-Path: X-Original-To: apmail-asterixdb-notifications-archive@minotaur.apache.org Delivered-To: apmail-asterixdb-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3266818FE9 for ; Fri, 2 Oct 2015 23:22:01 +0000 (UTC) Received: (qmail 18345 invoked by uid 500); 2 Oct 2015 23:22:01 -0000 Delivered-To: apmail-asterixdb-notifications-archive@asterixdb.apache.org Received: (qmail 18319 invoked by uid 500); 2 Oct 2015 23:22:01 -0000 Mailing-List: contact notifications-help@asterixdb.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.incubator.apache.org Delivered-To: mailing list notifications@asterixdb.incubator.apache.org Received: (qmail 18310 invoked by uid 99); 2 Oct 2015 23:22:00 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Oct 2015 23:22:00 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 70D3CC17DB for ; Fri, 2 Oct 2015 23:22:00 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.92 X-Spam-Level: X-Spam-Status: No, score=0.92 tagged_above=-999 required=6.31 tests=[SPF_FAIL=0.919, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id l1Uc7HqY3vcw for ; Fri, 2 Oct 2015 23:21:51 +0000 (UTC) Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu [128.195.14.130]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with ESMTP id B3F7820592 for ; Fri, 2 Oct 2015 23:21:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by unhygienix.ics.uci.edu (Postfix) with ESMTP id 2C462241001; Fri, 2 Oct 2015 16:19:16 -0700 (PDT) Date: Fri, 2 Oct 2015 16:19:16 -0700 From: "Ian Maxon (Code Review)" To: Chris Hillery CC: Jenkins , Till Westmann Reply-To: imaxon@apache.org X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: Adding 'cleanjson' output format, along with implementation ... X-Gerrit-Change-Id: I5c37d3b5aad7f286eba1cb8cb5f05ad456a6521c X-Gerrit-ChangeURL: X-Gerrit-Commit: 2b77b4e8ea619a0724ffc2a97e878556aad3bf7c In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.8.4 Message-Id: <20151002231916.2C462241001@unhygienix.ics.uci.edu> Ian Maxon has posted comments on this change. Change subject: Adding 'cleanjson' output format, along with implementation of lists. ...................................................................... Patch Set 7: Code-Review+1 (3 comments) Just a few nits https://asterix-gerrit.ics.uci.edu/#/c/361/7/asterix-common/src/main/java/org/apache/asterix/common/feeds/FeedMessageService.java File asterix-common/src/main/java/org/apache/asterix/common/feeds/FeedMessageService.java: Line 76: LOGGER.warning("LOSSLESS_JSON exception in parsing message " + message + " exception [" + jse.getMessage() + "]"); s/JSON/LOSSLESS_JSON/g isn't quite right here :) https://asterix-gerrit.ics.uci.edu/#/c/361/7/asterix-common/src/main/java/org/apache/asterix/common/feeds/message/FeedMessageService.java File asterix-common/src/main/java/org/apache/asterix/common/feeds/message/FeedMessageService.java: Line 76: LOGGER.warning("LOSSLESS_JSON Exception in parsing message " + message); Ditto... https://asterix-gerrit.ics.uci.edu/#/c/361/7/asterix-om/src/main/java/org/apache/asterix/formats/base/IDataFormat.java File asterix-om/src/main/java/org/apache/asterix/formats/base/IDataFormat.java: Line 67: Can getJSONPrinterFactoryProvider be changed to getLosslessJSONPrinterFactoryProvider? -- To view, visit https://asterix-gerrit.ics.uci.edu/361 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c37d3b5aad7f286eba1cb8cb5f05ad456a6521c Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Chris Hillery Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: Yes