asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Murtadha Hubail (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1058: make Asterix compatible with lazy LSM memory...
Date Thu, 29 Oct 2015 10:51:55 GMT
Murtadha Hubail has posted comments on this change.

Change subject: ASTERIXDB-1058: make Asterix compatible with lazy LSM memory allocation
......................................................................


Patch Set 6:

(7 comments)

https://asterix-gerrit.ics.uci.edu/#/c/408/6/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java
File asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java:

Line 279:                 assert vbcs != null;
> asserts have a few disadvantages: 1) they need to be enabled to actually be
Done


Line 607:             throw new HyracksDataException("Failed to deallocate memory for dataset
with ID " + datasetId
> s/deallocate/allocate/
Done


Line 625:                 dsInfo.memoryAllocated = true;
> It would be nice, if "memoryAllocated" (and all other fields) would be part
Done


Line 648:     @Override
> If this method disappears from the IIndexLifecycleManager, we don't need it
Removed.


Line 665:     //This method is currently never used but it is implemented in case of memory
management design change.
> ditto
Removed.


https://asterix-gerrit.ics.uci.edu/#/c/408/6/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/TestRuntimeContextProvider.java
File asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/TestRuntimeContextProvider.java:

Line 142:         @Override
> If this method disappears from the IIndexLifecycleManager, we don't need it
Removed.


Line 147:         @Override
> ditto
Removed.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/408
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ea1eb129fe3043d43b077473dc29d17a97dfcc2
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Carey <dtabass@gmail.com>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Young-Seok Kim <kisskys@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message